Bug 105303
| Summary: | [Meta] Move ImageDiff to the Tools directory root | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Thiago Marcos P. Santos <tmpsantos> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | andersca, cmarcelo, eric, gustavo, hausmann, kenneth, laszlo.gombos, ossy, pnormand, rafael.lobo, roger_fong, rwlbuis |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 105305, 105420, 105421 | ||
| Bug Blocks: | |||
Thiago Marcos P. Santos
ImageDiff does not depend on DumpRenderTree but for legacy reasons it lives inside the DRT folder, even though it is needed when running pixel tests for WK2. Some ports like Qt and EFL have the option to build only WebKit2 and it turns to be a problem for directory oriented buildsystems. We should move it to the Tools root directory and follow the same directory structure as we have for the MiniBrowser (Tools/ImageDiff/[port]/).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Csaba Osztrogonác
It is in Tools' root long time ago.