Bug 105288

Summary: [EFL] ImageDiff does not build on WebKit2 only builds
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: WebKit EFLAssignee: Thiago Marcos P. Santos <tmpsantos>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Thiago Marcos P. Santos
Reported 2012-12-18 07:12:57 PST
The tool lives inside DumpRenderTree (although it doesn't depend on it). It also link with tons of unnecessary libraries for no apparent reason. We should move it to a neutral place and enable it by default regardless of what version of the WebKit API you are building.
Attachments
Patch (29.50 KB, patch)
2012-12-18 07:16 PST, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1 2012-12-18 07:16:35 PST
Created attachment 179936 [details] Patch
Laszlo Gombos
Comment 2 2012-12-18 07:34:14 PST
I would move the ImageDiff directory at the same level as DumpRenderTree - e.g. Tools/ImageDiff(/efl). We should probably check with other ports for their preference for the location.
WebKit Review Bot
Comment 3 2012-12-18 07:50:31 PST
Comment on attachment 179936 [details] Patch Clearing flags on attachment: 179936 Committed r138019: <http://trac.webkit.org/changeset/138019>
WebKit Review Bot
Comment 4 2012-12-18 07:50:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.