Bug 105245

Summary: Allow position:sticky elements to be moved by the scrolling thread
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, enne, eric, jamesr, nduca, ojan, rniwa, simon.fraser, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104276    
Attachments:
Description Flags
Patch bdakin: review+

Simon Fraser (smfr)
Reported 2012-12-17 20:13:44 PST
Allow position:sticky elements to be moved by the scrolling thread
Attachments
Patch (53.22 KB, patch)
2012-12-17 20:25 PST, Simon Fraser (smfr) 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-12-17 20:25:56 PST
Created attachment 179870 [details] Patch
Alexey Proskuryakov
Comment 2 2012-12-18 10:09:32 PST
Simon says that this will mostly fix bug 104276.
Beth Dakin
Comment 3 2012-12-18 12:16:12 PST
Comment on attachment 179870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179870&action=review It seems like there should be a way to share a little more code between ScrollingStateFixedNode/ScrollingStateStickyNode and ScrollingTreeFixedNode/ScrollingTreeStickyNode, but I think this is fine for now. > Source/WebCore/rendering/RenderLayerCompositor.cpp:2723 > + if (m_renderView->document()->ownerElement()) You should fix the comment here. It still claims that we don't yet support sticky.
Simon Fraser (smfr)
Comment 4 2012-12-18 15:33:16 PST
http://trac.webkit.org/changeset/138076
Ryosuke Niwa
Comment 5 2012-12-20 12:39:06 PST
This patch appears to have caused test failures on WK2 bots: e.g. http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r138276%20(4305)/results.html
Note You need to log in before you can comment on or make changes to this bug.