Bug 105242

Summary: [Shadow] LargeDistributionWithLayout.html should be updated
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 102646    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Shinya Kawanaka
Reported 2012-12-17 19:20:31 PST
This test was written when distribution was O(N^2). Now it's almost O(N), this test should have more loops.
Attachments
Patch (1.89 KB, patch)
2012-12-17 19:23 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (2.08 KB, patch)
2012-12-17 21:20 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.06 KB, patch)
2012-12-17 22:57 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-12-17 19:23:38 PST
Created attachment 179864 [details] Patch
Ryosuke Niwa
Comment 2 2012-12-17 19:32:40 PST
Comment on attachment 179864 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179864&action=review > PerformanceTests/ChangeLog:9 > + Since this test was written when distribution took O(N^2). However, now it's almost O(N), so this test finishes > + in very short time. Also, this test contains a some error to cause test failure, it also should be fixed. We should use run/s in this test instead.
Shinya Kawanaka
Comment 3 2012-12-17 21:20:07 PST
Created attachment 179875 [details] Patch
Ryosuke Niwa
Comment 4 2012-12-17 21:41:28 PST
Comment on attachment 179875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179875&action=review > PerformanceTests/ShadowDOM/LargeDistributionWithLayout.html:26 > + window.content = document.createElement('content'); Why don't we just declare this variable outside of the function? So this test wasn't doing anything useful before? > PerformanceTests/ShadowDOM/LargeDistributionWithLayout.html:27 > + window.shadowRoot = host.webkitCreateShadowRoot(); I don't think we need to expose this variable. It's not used elsewhere.
Shinya Kawanaka
Comment 5 2012-12-17 22:48:25 PST
> Why don't we just declare this variable outside of the function? So this test wasn't doing anything useful before? Unfortunately it is true... It's my fault. Maybe I wrongly uploaded a bit old version and it's committed... Basically this test and all tests in ShadowDOM/ are off by default, but they're used in our environment to track ShadowDOM performance.
Shinya Kawanaka
Comment 6 2012-12-17 22:57:00 PST
Created attachment 179880 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-12-17 23:29:56 PST
Comment on attachment 179880 [details] Patch for landing Clearing flags on attachment: 179880 Committed r137990: <http://trac.webkit.org/changeset/137990>
WebKit Review Bot
Comment 8 2012-12-17 23:30:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.