Bug 105237

Summary: DFG: Refactor DFGCorrectableJumpPoint to reduce size of OSRExit data
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, ossy, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 105270    
Bug Blocks:    
Attachments:
Description Flags
Patch
fpizlo: review+, msaboff: commit-queue-
Patch with change in CMakeLists.txt missed in first patch
webkit.review.bot: commit-queue-
Added reviewer information. none

Michael Saboff
Reported 2012-12-17 18:11:32 PST
The DFGCorrectableJumpPoint class contains information used during DFG compilation (the failure case Jump) phase as well as during code execution (offset to the patchable jump). These objects are part of the code block, one per OSRExit, therefore it makes sense to eliminate the information needed during compilation. DFGCorrectableJumpPoint should be refactored and effectively split.
Attachments
Patch (31.20 KB, patch)
2012-12-17 18:20 PST, Michael Saboff 		fpizlo: review+
msaboff: commit-queue-
DetailsFormatted DiffDiff
Patch with change in CMakeLists.txt missed in first patch (31.72 KB, patch)
2012-12-17 18:29 PST, Michael Saboff 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Added reviewer information. (31.72 KB, patch)
2012-12-17 18:54 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-12-17 18:20:57 PST
Created attachment 179845 [details] Patch
Michael Saboff
Comment 2 2012-12-17 18:29:16 PST
Created attachment 179848 [details] Patch with change in CMakeLists.txt missed in first patch
WebKit Review Bot
Comment 3 2012-12-17 18:42:07 PST
Comment on attachment 179848 [details] Patch with change in CMakeLists.txt missed in first patch Rejecting attachment 179848 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15355987
Michael Saboff
Comment 4 2012-12-17 18:54:02 PST
Created attachment 179856 [details] Added reviewer information.
WebKit Review Bot
Comment 5 2012-12-17 19:52:12 PST
Comment on attachment 179856 [details] Added reviewer information. Clearing flags on attachment: 179856 Committed r137976: <http://trac.webkit.org/changeset/137976>
WebKit Review Bot
Comment 6 2012-12-17 19:52:17 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 7 2012-12-18 02:34:27 PST
(In reply to comment #5) > (From update of attachment 179856 [details]) > Clearing flags on attachment: 179856 > > Committed r137976: <http://trac.webkit.org/changeset/137976> It broke the ARMv7 build - see https://bugs.webkit.org/show_bug.cgi?id=105270 for details.
Note You need to log in before you can comment on or make changes to this bug.