Bug 105236

Summary: run-perf-tests should warn (loudly) if you're using a Debug build
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dpranke, glenn, ossy, pdr, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Eric Seidel (no email)
Reported 2012-12-17 18:00:23 PST
run-perf-tests should warn (loudly) if you're using a Debug build Trying to get perf numbers out of a Debug build is folly. Sure, we can support people running with run-perf-tests --debug, but we should scream at them to make sure the innocent bystanders don't get confused by their checkout being in --debug mode (set-webkit-configuration --debug) and run-perf-tests giving them debug numbers. pdr was bitten by this earlier today.
Attachments
Patch (2.01 KB, patch)
2013-11-14 04:10 PST, Éva Balázsfalvi 		no flags
DetailsFormatted DiffDiff
Patch (1.55 KB, patch)
2013-11-14 06:56 PST, Éva Balázsfalvi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Éva Balázsfalvi
Comment 1 2013-11-14 04:10:53 PST
Created attachment 216916 [details] Patch
Csaba Osztrogonác
Comment 2 2013-11-14 04:30:04 PST
Comment on attachment 216916 [details] Patch The idea is good, but this patch has an issue: I get this warning too if the default configuration is Debug, but I passed --relase as command line argument.
Éva Balázsfalvi
Comment 3 2013-11-14 06:56:41 PST
Created attachment 216929 [details] Patch
Csaba Osztrogonác
Comment 4 2013-11-14 07:10:34 PST
Comment on attachment 216929 [details] Patch It sounds much more better, r=me.
WebKit Commit Bot
Comment 5 2013-11-14 07:36:01 PST
Comment on attachment 216929 [details] Patch Clearing flags on attachment: 216929 Committed r159285: <http://trac.webkit.org/changeset/159285>
WebKit Commit Bot
Comment 6 2013-11-14 07:36:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.