Bug 105233

Summary: Track menu needs localization
Product: WebKit Reporter: Dean Jackson <dino>
Component: MediaAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adamk, eric.carlson, eric, feature-media-reviews, gyuyoung.kim, ojan.autocc, rakuco, silviapf, vcarbune, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch eric.carlson: review+

Description Dean Jackson 2012-12-17 17:37:19 PST 
The static text labels in the track menu need to be localizable.
Comment 1 Radar WebKit Bug Importer 2012-12-17 17:37:59 PST 
<rdar://problem/12898144>
Comment 2 Dean Jackson 2012-12-18 13:28:21 PST 
Created attachment 180015 [details]
Patch
Comment 3 Dean Jackson 2012-12-18 13:59:03 PST 
Created attachment 180018 [details]
Patch
Comment 4 Dean Jackson 2012-12-18 14:34:18 PST 
Committed r138071: <http://trac.webkit.org/changeset/138071>
Comment 5 Adam Klein 2012-12-18 16:00:40 PST 
+cr-ews owners: what's up with the cr-linux EWS jobs on this bug? They claim to have passed but this patch has linking errors on all Chromium ports.
Comment 6 Dean Jackson 2012-12-18 16:08:56 PST 
Silvia, HEADS UP.

If Chromium enables this code, you'll have to update my build-fix in r138079
I made all the strings empty for Chromium. There was some discussion on IRC about where the LocalizedStrings.cpp file for Chromium should be.
Comment 7 Silvia Pfeiffer 2012-12-28 12:07:04 PST 
OK. Adding Victor to this, too, to make sure we don't forget.