Bug 105221

Summary: Butterfly::growArrayRight shouldn't be called on null Butterfly objects
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mark Hahnenberg
Reported 2012-12-17 15:26:20 PST
Currently we depend upon the fact that Butterfly::growArrayRight works with null Butterfly objects purely by coincidence. We should add a new static function that null checks the old Butterfly object and creates a new one if it's null, or calls growArrayRight if it isn't for use in the couple of places in JSObject that expect such behavior to work.
Attachments
Patch (4.60 KB, patch)
2012-12-17 16:00 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (4.58 KB, patch)
2012-12-17 16:53 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-12-17 16:00:29 PST
Created attachment 179821 [details] Patch
Early Warning System Bot
Comment 2 2012-12-17 16:07:25 PST
Comment on attachment 179821 [details] Patch Attachment 179821 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15360953
Early Warning System Bot
Comment 3 2012-12-17 16:08:12 PST
Comment on attachment 179821 [details] Patch Attachment 179821 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15375881
Mark Hahnenberg
Comment 4 2012-12-17 16:53:23 PST
Created attachment 179834 [details] Patch
Mark Hahnenberg
Comment 5 2012-12-17 17:04:57 PST
Committed r137961: <http://trac.webkit.org/changeset/137961>
Note You need to log in before you can comment on or make changes to this bug.