Bug 105199

Summary: [BlackBerry] Restructure the render queue to process multiple tiles at once
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: WebKit BlackBerryAssignee: Jakob Petsovits <jpetsovits>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, manyoso, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 105302    
Attachments:
Description Flags
Patch
none
Build fix none

Jakob Petsovits
Reported 2012-12-17 11:44:52 PST
Since my last big commit, r136442, the BackingStore's render() function is able to fetch multiple back buffers and swap them into the user interface thread in one go. However, it turns out that this is not enough to actually render to all of the available back buffers at once. So we block more and don't really take good advantage of having multiple back buffers available. We should do whatever's necessary to actually make use of this feature. In the words of our co-op Bryan, "Faster Power!". Patch below. (Waiting for Arvid to finish his internal review so I can credit him in the commit message.)
Attachments
Patch (110.32 KB, patch)
2012-12-18 08:01 PST, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Build fix (1.85 KB, patch)
2012-12-18 13:15 PST, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2012-12-18 08:01:36 PST
Created attachment 179942 [details] Patch
WebKit Review Bot
Comment 2 2012-12-18 08:38:23 PST
Comment on attachment 179942 [details] Patch Clearing flags on attachment: 179942 Committed r138024: <http://trac.webkit.org/changeset/138024>
WebKit Review Bot
Comment 3 2012-12-18 08:38:26 PST
All reviewed patches have been landed. Closing bug.
Jakob Petsovits
Comment 4 2012-12-18 13:04:14 PST
Apparently I fail at merge conflict resolution. Upstream has bdakin's LayoutMilestones patch which my development branch yet has to pick up, it indented a block in FrameLoaderClientBlackBerry. On resolving the conflict, I replaced blitVisibleTiles() (intended) but failed to delete the clearVisibleTiles() line, resulting in a build error as that function has been removed. Patch forthcoming, give me a sec.
Jakob Petsovits
Comment 5 2012-12-18 13:15:40 PST
Created attachment 180013 [details] Build fix
WebKit Review Bot
Comment 6 2012-12-18 13:45:15 PST
Comment on attachment 180013 [details] Build fix Clearing flags on attachment: 180013 Committed r138066: <http://trac.webkit.org/changeset/138066>
WebKit Review Bot
Comment 7 2012-12-18 13:45:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.