Bug 105191

Summary:

[GTK][GStreamer] Fullscreen option in video element context menu not working

Product:

WebKit

Reporter:

Eduardo Lima Mitev <elima>

Component:

WebKitGTK

Assignee:

Xabier Rodríguez Calvar <calvaris>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, commit-queue, pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

117551

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from APPLE-EWS-3 for win-future	none
Patch	none

Eduardo Lima Mitev

Reported 2012-12-17 09:46:09 PST

1) run-launcher --gtk --enable-fullscreen=TRUE 2) Open page with video element and movie (i,e: http://chaos.troll.no/~tavestbo/webkit/mediaelement/) 3) Right click player, context menu opens. 4) Select "Switch Video to Fullscreen" Nothing happens, however the fullscreen button in the controls bar does work. Same with WebKit 2.

Attachments
Patch (4.53 KB, patch) 2013-06-14 04:09 PDT, Xabier Rodríguez Calvar	no flags	Details Formatted Diff Diff
Archive of layout-test-results from APPLE-EWS-3 for win-future (786.47 KB, application/zip) 2013-06-14 15:35 PDT, Build Bot	no flags	Details
Patch (4.62 KB, patch) 2013-06-17 06:57 PDT, Xabier Rodríguez Calvar	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Philippe Normand

Comment 1 2013-04-25 07:59:27 PDT

Is that issue still valid? It'd be nice to fix it for WK2 at least.

Xabier Rodríguez Calvar

Comment 2 2013-05-24 03:22:24 PDT

(In reply to comment #1) > Is that issue still valid? It'd be nice to fix it for WK2 at least. Yes, still valid.

Xabier Rodríguez Calvar

Comment 3 2013-06-14 04:09:31 PDT

Created attachment 204697 [details] Patch Removed the use of native controls and updated the test expectations.

Xabier Rodríguez Calvar

Comment 4 2013-06-14 10:03:04 PDT

(In reply to comment #3) > Created an attachment (id=204697) [details] The crash I added to the expectations disappears when the patch proposed for bug 117551, hence, adding dependency.

Build Bot

Comment 5 2013-06-14 15:35:25 PDT

Comment on attachment 204697 [details] Patch Attachment 204697 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/922054 New failing tests: fast/media/mq-transform-03.html fast/media/mq-transform-02.html platform/win/accessibility/multiple-select-element-role.html

Build Bot

Comment 6 2013-06-14 15:35:27 PDT

Created attachment 204739 [details] Archive of layout-test-results from APPLE-EWS-3 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-3 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

Xabier Rodríguez Calvar

Comment 7 2013-06-14 16:27:38 PDT

(In reply to comment #5) > New failing tests: > fast/media/mq-transform-03.html > fast/media/mq-transform-02.html > platform/win/accessibility/multiple-select-element-role.html Is it me or this doesn't make sense according to my patch?

Xabier Rodríguez Calvar

Comment 8 2013-06-17 06:57:40 PDT

Created attachment 204819 [details] Patch Removed the use of native controls and updated the test expectations.

Xabier Rodríguez Calvar

Comment 9 2013-06-17 09:16:41 PDT

Comment on attachment 204819 [details] Patch Removing cq flag as I cannot watch the bots now.

WebKit Commit Bot

Comment 10 2013-06-18 01:18:58 PDT

Comment on attachment 204819 [details] Patch Clearing flags on attachment: 204819 Committed r151674: <http://trac.webkit.org/changeset/151674>

WebKit Commit Bot

Comment 11 2013-06-18 01:19:00 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.