Summary: | [GTK][GStreamer] Fullscreen option in video element context menu not working | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eduardo Lima Mitev <elima> | ||||||||
Component: | WebKitGTK | Assignee: | Xabier Rodríguez Calvar <calvaris> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | calvaris, commit-queue, pnormand | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 117551 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Eduardo Lima Mitev
2012-12-17 09:46:09 PST
Is that issue still valid? It'd be nice to fix it for WK2 at least. (In reply to comment #1) > Is that issue still valid? It'd be nice to fix it for WK2 at least. Yes, still valid. Created attachment 204697 [details]
Patch
Removed the use of native controls and updated the test expectations.
(In reply to comment #3) > Created an attachment (id=204697) [details] The crash I added to the expectations disappears when the patch proposed for bug 117551, hence, adding dependency. Comment on attachment 204697 [details] Patch Attachment 204697 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/922054 New failing tests: fast/media/mq-transform-03.html fast/media/mq-transform-02.html platform/win/accessibility/multiple-select-element-role.html Created attachment 204739 [details]
Archive of layout-test-results from APPLE-EWS-3 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-3 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
(In reply to comment #5) > New failing tests: > fast/media/mq-transform-03.html > fast/media/mq-transform-02.html > platform/win/accessibility/multiple-select-element-role.html Is it me or this doesn't make sense according to my patch? Created attachment 204819 [details]
Patch
Removed the use of native controls and updated the test expectations.
Comment on attachment 204819 [details]
Patch
Removing cq flag as I cannot watch the bots now.
Comment on attachment 204819 [details] Patch Clearing flags on attachment: 204819 Committed r151674: <http://trac.webkit.org/changeset/151674> All reviewed patches have been landed. Closing bug. |