Bug 105159

Summary: [EFL] Add ecore_imf_evas to FindEcore.cmake
Product: WebKit Reporter: Halton Huo <halton.huo>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, gyuyoung.kim, lucas.de.marchi, ojan.autocc, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Halton Huo
Reported 2012-12-17 03:33:45 PST
ecore_imf_evas is a separate library, we should add ecore_imf_evas as well. $ls WebKit/WebKitBuild/Dependencies/Root/lib64/libecore_imf*.so WebKit/WebKitBuild/Dependencies/Root/lib64/libecore_imf_evas.so WebKit/WebKitBuild/Dependencies/Root/lib64/libecore_imf.so
Attachments
Patch (3.57 KB, patch)
2012-12-17 03:53 PST, Halton Huo 		no flags
DetailsFormatted DiffDiff
Patch (2.51 KB, patch)
2012-12-17 16:54 PST, Halton Huo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Halton Huo
Comment 1 2012-12-17 03:53:55 PST
Created attachment 179711 [details] Patch
Laszlo Gombos
Comment 2 2012-12-17 08:19:26 PST
Comment on attachment 179711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179711&action=review Make sense to me, except the WTF changes. > Source/WTF/wtf/PlatformEfl.cmake:25 > + ${ECORE_IMF_EVAS_LIBRARIES} Is this really necessary ? It seems to me that WTF is not using ECORE_IMF_EVAS_LIBRARIES.
Halton Huo
Comment 3 2012-12-17 16:54:07 PST
Created attachment 179835 [details] Patch
Laszlo Gombos
Comment 4 2012-12-17 17:31:17 PST
Comment on attachment 179835 [details] Patch r=me.
WebKit Review Bot
Comment 5 2012-12-17 18:40:59 PST
Comment on attachment 179835 [details] Patch Clearing flags on attachment: 179835 Committed r137969: <http://trac.webkit.org/changeset/137969>
WebKit Review Bot
Comment 6 2012-12-17 18:41:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.