Bug 105138

Summary:

When the usergesture of mousedown is consumed, mouseup shouldn't have a user gesture indicator

Product:

WebKit

Reporter:

jochen

Component:

UI Events

Assignee:

jochen

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cdn, dglazkov, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Layout test	none
Patch	none

Description jochen 2012-12-16 15:22:46 PST

just came across a pop-under which does the popup creation in mousedown and the hiding in mousedown.

Can probably be fixed by using the same UserGestureIndicator::Token for related events

Comment 1 jochen 2013-01-09 14:06:36 PST

Created attachment 181979 [details]
Layout test

Comment 2 jochen 2013-01-11 00:21:27 PST

Created attachment 182278 [details]
Patch

Comment 3 Adam Barth 2013-01-11 01:45:15 PST

Comment on attachment 182278 [details]
Patch

Nice solution.

Comment 4 WebKit Review Bot 2013-01-11 02:09:13 PST

Comment on attachment 182278 [details]
Patch

Clearing flags on attachment: 182278

Committed r139419: <http://trac.webkit.org/changeset/139419>

Comment 5 WebKit Review Bot 2013-01-11 02:09:16 PST

All reviewed patches have been landed.  Closing bug.