Bug 105110

Summary: [BlackBerry] Clean up allocated memory from InputMethodSupport
Product: WebKit Reporter: Nima Ghanavatian <nima.ghanavatian>
Component: WebKit BlackBerryAssignee: Nima Ghanavatian <nghanavatian>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Nima Ghanavatian
Reported 2012-12-15 14:38:08 PST
We are deep copying the struct sent by IMF as they clean up as soon as we return. Free once we're done with it, since we only need the length and location.
Attachments
Patch (2.25 KB, patch)
2012-12-15 14:40 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (1.56 KB, patch)
2012-12-15 15:02 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nima Ghanavatian
Comment 1 2012-12-15 14:40:34 PST
Created attachment 179618 [details] Patch
Rob Buis
Comment 2 2012-12-15 14:41:51 PST
Comment on attachment 179618 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2012-12-15 14:43:36 PST
Comment on attachment 179618 [details] Patch Rejecting attachment 179618 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: s). patching file Source/WebKit/blackberry/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp Hunk #1 succeeded at 688 (offset -10 lines). Hunk #2 FAILED at 2270. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15366174
Nima Ghanavatian
Comment 4 2012-12-15 15:02:01 PST
Created attachment 179622 [details] Patch
Rob Buis
Comment 5 2012-12-15 15:04:45 PST
Comment on attachment 179622 [details] Patch Looks good.
WebKit Review Bot
Comment 6 2012-12-15 15:41:16 PST
Comment on attachment 179622 [details] Patch Clearing flags on attachment: 179622 Committed r137816: <http://trac.webkit.org/changeset/137816>
WebKit Review Bot
Comment 7 2012-12-15 15:41:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.