Bug 105098

Summary: Move calculation of caches sizes based on the cache model to CacheModel.h/cpp
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, gyuyoung.kim, menard, ossy, rakuco, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 105152    
Bug Blocks:    
Attachments:
Description Flags
Patch andersca: review+, webkit-ews: commit-queue-

Sam Weinig
Reported 2012-12-15 11:43:59 PST
Move calculation of caches sizes based on the cache model to CacheModel.h/cpp
Attachments
Patch (21.20 KB, patch)
2012-12-15 11:47 PST, Sam Weinig 		andersca: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2012-12-15 11:47:24 PST
Created attachment 179603 [details] Patch
WebKit Review Bot
Comment 2 2012-12-15 11:53:31 PST
Attachment 179603 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebKit2/Shared/CacheModel.h:37: The parameter name "cacheModel" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2012-12-15 11:56:50 PST
Comment on attachment 179603 [details] Patch Attachment 179603 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15361187
EFL EWS Bot
Comment 4 2012-12-15 12:08:31 PST
Comment on attachment 179603 [details] Patch Attachment 179603 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15355171
Sam Weinig
Comment 5 2012-12-15 17:22:40 PST
http://trac.webkit.org/changeset/137803
Csaba Osztrogonác
Comment 6 2012-12-17 00:08:19 PST
(In reply to comment #5) > http://trac.webkit.org/changeset/137803 It broke the Qt Windows build - fix is in https://bugs.webkit.org/show_bug.cgi?id=105152
Note You need to log in before you can comment on or make changes to this bug.