Bug 105081

Summary: Remove in-band text tracks when media element's src changes
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, feature-media-reviews, ojan.autocc, pnormand, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Eric Carlson
Reported 2012-12-14 18:59:21 PST
All in-band tracks removed from the media element when its src changes.
Attachments
Proposed patch (10.03 KB, patch)
2012-12-14 19:12 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-12-14 18:59:42 PST
<rdar://problem/12887984>
Eric Carlson
Comment 2 2012-12-14 19:12:50 PST
Created attachment 179576 [details] Proposed patch
WebKit Review Bot
Comment 3 2012-12-14 20:04:55 PST
Comment on attachment 179576 [details] Proposed patch Attachment 179576 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15317876 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Eric Carlson
Comment 4 2012-12-15 08:03:18 PST
(In reply to comment #3) > (From update of attachment 179576 [details]) > Attachment 179576 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15317876 > > New failing tests: > inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html This is has nothing to do with these change.
Sam Weinig
Comment 5 2012-12-15 18:31:53 PST
Comment on attachment 179576 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=179576&action=review > Source/WebCore/html/HTMLMediaElement.cpp:2788 > + beginIgnoringTrackDisplayUpdateRequests(); It might add some point make sense to add an RAII object to use scope to control this bounding.
WebKit Review Bot
Comment 6 2012-12-16 11:27:16 PST
Comment on attachment 179576 [details] Proposed patch Clearing flags on attachment: 179576 Committed r137844: <http://trac.webkit.org/changeset/137844>
WebKit Review Bot
Comment 7 2012-12-16 11:27:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.