Bug 105077

Summary: webkitpy: move --lint-test-files code into its own module
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103824, 105078    
Attachments:
Description Flags
Patch
none
fix main() call in lint-test-expectations eric: review+

Dirk Pranke
Reported 2012-12-14 18:17:34 PST
webkitpy: move --lint-test-files code into its own module
Attachments
Patch (21.70 KB, patch)
2012-12-14 18:18 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
fix main() call in lint-test-expectations (21.72 KB, patch)
2012-12-14 18:22 PST, Dirk Pranke 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-12-14 18:18:39 PST
Created attachment 179569 [details] Patch
Dirk Pranke
Comment 2 2012-12-14 18:22:59 PST
Created attachment 179570 [details] fix main() call in lint-test-expectations
Eric Seidel (no email)
Comment 3 2012-12-14 23:37:59 PST
Comment on attachment 179570 [details] fix main() call in lint-test-expectations View in context: https://bugs.webkit.org/attachment.cgi?id=179570&action=review Looks like you're mostly moving code. LGTM. > Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py:49 > +def lint(host, options, logging_stream): Eventually we should probably make this a class so we can break it down into smaller helper methods. :)
Dirk Pranke
Comment 4 2012-12-17 13:51:30 PST
Committed r137942: <http://trac.webkit.org/changeset/137942>
Note You need to log in before you can comment on or make changes to this bug.