Bug 105075

Summary:

Correct FrameView::scrollableAreaBoundingBox() calculation in the presence of transforms

Product:

WebKit

Reporter:

Tien-Ren Chen <trchen>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aelias, andersca, bdakin, dglazkov, jchaffraix, simon.fraser, wangxianzhu, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

105546

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Tien-Ren Chen

Reported 2012-12-14 17:18:26 PST

Correct FrameView::scrollableAreaBoundingBox() calculation

Attachments
Patch (1.66 KB, patch) 2012-12-14 17:21 PST, Tien-Ren Chen	no flags	Details Formatted Diff Diff
Patch (10.33 KB, patch) 2012-12-21 19:42 PST, Tien-Ren Chen	no flags	Details Formatted Diff Diff
Patch (10.49 KB, patch) 2012-12-21 19:58 PST, Tien-Ren Chen	no flags	Details Formatted Diff Diff
Patch (10.52 KB, patch) 2013-01-08 15:04 PST, Tien-Ren Chen	no flags	Details Formatted Diff Diff
Patch (19.31 KB, patch) 2013-01-10 18:22 PST, Tien-Ren Chen	no flags	Details Formatted Diff Diff
Patch (19.37 KB, patch) 2013-01-10 18:29 PST, Tien-Ren Chen	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Tien-Ren Chen

Comment 1 2012-12-14 17:21:32 PST

Created attachment 179564 [details] Patch

Tien-Ren Chen

Comment 2 2012-12-14 17:23:39 PST

*** Bug 104730 has been marked as a duplicate of this bug. ***

Simon Fraser (smfr)

Comment 3 2012-12-15 16:44:16 PST

Comment on attachment 179564 [details] Patch Needs a testcase. Does it do the right thing if the frame has border and padding?

Tien-Ren Chen

Comment 4 2012-12-21 19:42:14 PST

Created attachment 180588 [details] Patch

Tien-Ren Chen

Comment 5 2012-12-21 19:46:11 PST

Here is a test case based on Xianzhu's work in 105546. The border and padding will be included in the non-fast scrollable region, which is a false positive. :( I will correct that in next upload.

Tien-Ren Chen

Comment 6 2012-12-21 19:58:45 PST

Created attachment 180589 [details] Patch

Build Bot

Comment 7 2012-12-21 20:26:18 PST

Comment on attachment 180589 [details] Patch Attachment 180589 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15445720 New failing tests: scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html

WebKit Review Bot

Comment 8 2012-12-21 20:43:01 PST

Comment on attachment 180589 [details] Patch Attachment 180589 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15445727 New failing tests: scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html

Simon Fraser (smfr)

Comment 9 2013-01-02 21:39:45 PST

Comment on attachment 180589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180589&action=review > Source/WebCore/ChangeLog:3 > + Correct FrameView::scrollableAreaBoundingBox() calculation This should say why (... in the presence of transforms).

Tien-Ren Chen

Comment 10 2013-01-08 15:04:37 PST

Created attachment 181777 [details] Patch

Tien-Ren Chen

Comment 11 2013-01-08 15:05:34 PST

Comment on attachment 181777 [details] Patch Amended ChangeLog title and rebased.

Build Bot

Comment 12 2013-01-08 15:42:58 PST

Comment on attachment 181777 [details] Patch Attachment 181777 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15774132 New failing tests: scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html

Tien-Ren Chen

Comment 13 2013-01-10 18:22:41 PST

Created attachment 182235 [details] Patch

Tien-Ren Chen

Comment 14 2013-01-10 18:29:21 PST

Created attachment 182238 [details] Patch

WebKit Review Bot

Comment 15 2013-01-10 19:13:57 PST

Comment on attachment 182238 [details] Patch Attachment 182238 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15804165 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

Tien-Ren Chen

Comment 16 2013-01-11 15:56:59 PST

(In reply to comment #15) > (From update of attachment 182238 [details]) > Attachment 182238 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15804165 > > New failing tests: > inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html This is a flake. The patch is identical with the last one (except with ChangeLog title amended). PTAL, thanks!

Tien-Ren Chen

Comment 17 2013-01-14 14:42:23 PST

Ping. Let's get this landed. The included layout test template for non-fast-scrollable region allows us to write many more tests. :)

WebKit Review Bot

Comment 18 2013-01-14 16:52:56 PST

Comment on attachment 182238 [details] Patch Clearing flags on attachment: 182238 Committed r139686: <http://trac.webkit.org/changeset/139686>

WebKit Review Bot

Comment 19 2013-01-14 16:53:01 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.