Bug 105070

Summary: [Chromium] Restore WebM EME canPlayType() expectations.
Product: WebKit Reporter: David Dorwin <ddorwin>
Component: New BugsAssignee: David Dorwin <ddorwin>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, scherkus, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

David Dorwin
Reported 2012-12-14 16:46:44 PST
[Chromium] Restore WebM EME canPlayType() expectations.
Attachments
Patch (1.68 KB, patch)
2012-12-14 16:47 PST, David Dorwin 		no flags
DetailsFormatted DiffDiff
Patch (1.58 KB, patch)
2012-12-19 12:23 PST, David Dorwin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Dorwin
Comment 1 2012-12-14 16:47:45 PST
Created attachment 179558 [details] Patch
David Dorwin
Comment 2 2012-12-14 16:55:14 PST
Will need cq+ after chromium_rev rolls to 173235 in http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS.
WebKit Review Bot
Comment 3 2012-12-14 19:46:28 PST
Comment on attachment 179558 [details] Patch Attachment 179558 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15311912 New failing tests: media/encrypted-media/encrypted-media-can-play-type-webm.html
WebKit Review Bot
Comment 4 2012-12-18 14:56:07 PST
Comment on attachment 179558 [details] Patch Rejecting attachment 179558 [details] from commit-queue. New failing tests: media/encrypted-media/encrypted-media-can-play-type-webm.html Full output: http://queues.webkit.org/results/15406317
David Dorwin
Comment 5 2012-12-18 16:58:33 PST
Comment on attachment 179558 [details] Patch This needs the code to have been built after the DEPS roll, which didn't appear to happen when it ran in the CQ last time.
WebKit Review Bot
Comment 6 2012-12-18 20:06:12 PST
Comment on attachment 179558 [details] Patch Rejecting attachment 179558 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: crypto/ppapi/cdm --revision 173055 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 56>At revision 173055. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Total errors found: 0 in 0 files Full output: http://queues.webkit.org/results/15408448
David Dorwin
Comment 7 2012-12-19 12:23:25 PST
Created attachment 180207 [details] Patch
Tony Chang
Comment 8 2012-12-20 12:43:53 PST
Comment on attachment 180207 [details] Patch Test is passing on all the bots.
WebKit Review Bot
Comment 9 2012-12-20 13:16:55 PST
Comment on attachment 180207 [details] Patch Clearing flags on attachment: 180207 Committed r138289: <http://trac.webkit.org/changeset/138289>
WebKit Review Bot
Comment 10 2012-12-20 13:16:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.