Bug 105000

Summary:

Allow built-in PDF plugin and plugin documents to auto-start

Product:

WebKit

Reporter:

Jon Lee <jonlee>

Component:

WebKit Misc.

Assignee:

Jon Lee <jonlee>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abecsi, andersca, ap, beidson, cmarcelo, japhet, menard, ojan.autocc, thorton, webkit-bug-importer, webkit-ews, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.8

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	sam: review+

Jon Lee

Reported 2012-12-14 01:13:42 PST

Give the loader client an opportunity to prevent a plug-in being snapshot. <rdar://problem/12633351>

Attachments
Patch (8.85 KB, patch) 2012-12-14 01:32 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (10.93 KB, patch) 2012-12-14 01:51 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (11.05 KB, patch) 2012-12-14 02:02 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch (10.30 KB, patch) 2012-12-16 00:41 PST, Jon Lee	sam: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Jon Lee

Comment 1 2012-12-14 01:32:45 PST

Created attachment 179447 [details] Patch

Early Warning System Bot

Comment 2 2012-12-14 01:41:10 PST

Comment on attachment 179447 [details] Patch Attachment 179447 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15311608

Jon Lee

Comment 3 2012-12-14 01:51:00 PST

Created attachment 179449 [details] Patch

Early Warning System Bot

Comment 4 2012-12-14 01:57:38 PST

Comment on attachment 179449 [details] Patch Attachment 179449 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15310645

Jon Lee

Comment 5 2012-12-14 02:02:35 PST

Created attachment 179452 [details] Patch

Tim Horton

Comment 6 2012-12-14 12:44:22 PST

Comment on attachment 179452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179452&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:161 > + WKBundlePageShouldSnapshotPlugInMIMETypeCallback shouldSnapshotPlugInMIMEType; Can you just throw this on the end of the API like this? How does versioning work?

Jon Lee

Comment 7 2012-12-14 12:46:16 PST

Tacking that function at the end is ok in this case, because the current version goes beyond what has shipped in previous Safari. When a product ships at a certain version, it's a hard stop, and we have to increment the number.

Jon Lee

Comment 8 2012-12-14 15:21:30 PST

Redefine the rules to: 1) PlugInDocs run automatically 2) Build-in PDF runs automatically 3) else snapshot

Jon Lee

Comment 9 2012-12-16 00:41:57 PST

Created attachment 179642 [details] Patch

Jon Lee

Comment 10 2012-12-16 18:44:53 PST

Committed r137868: <http://trac.webkit.org/changeset/137868>

Note You need to log in before you can comment on or make changes to this bug.