Bug 104991

Summary: Copy platform/win/fast/events/panScroll-* to platform/chromium-win/fast/events
Product: WebKit Reporter: yosin
Component: Tools / TestsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104764, 104998    
Attachments:
Description Flags
Patch 1
none
Patch 2 morrita: review+

yosin
Reported 2012-12-13 21:12:44 PST
Chromium-Win port also wants to use pan scroll tests.
Attachments
Patch 1 (11.86 KB, patch)
2012-12-13 21:51 PST, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (13.07 KB, patch)
2012-12-13 22:52 PST, yosin 		morrita: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-12-13 21:51:00 PST
Created attachment 179415 [details] Patch 1
yosin
Comment 2 2012-12-13 21:53:37 PST
Comment on attachment 179415 [details] Patch 1 Could you review this patch? Thanks in advance. All files, except for ChangeLog, are copied w/o modification.
WebKit Review Bot
Comment 3 2012-12-13 22:38:17 PST
Comment on attachment 179415 [details] Patch 1 Attachment 179415 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15312557 New failing tests: platform/chromium-win/fast/events/panScroll-nested-divs.html platform/chromium-win/fast/events/panScroll-event-fired.html platform/chromium-win/fast/events/panScroll-click-hyperlink.html
yosin
Comment 4 2012-12-13 22:52:30 PST
Created attachment 179420 [details] Patch 2
yosin
Comment 5 2012-12-13 23:47:36 PST
Comment on attachment 179420 [details] Patch 2 Could you review this patch? Thanks in advance. P.S. It seems cr-android bot has trouble fetching GIT files.
Hajime Morrita
Comment 6 2012-12-14 00:07:17 PST
Comment on attachment 179420 [details] Patch 2 r=me. Please add comments that mentions this does copy in separate change.
yosin
Comment 7 2012-12-14 00:15:54 PST
Reverted r137719 for reason: Wrong commit Committed r137722: <http://trac.webkit.org/changeset/137722>
yosin
Comment 8 2012-12-14 00:20:46 PST
Reverted r137720 for reason: Wrong Commit Committed r137723: <http://trac.webkit.org/changeset/137723>
yosin
Comment 9 2012-12-14 00:29:44 PST
Committed: http://trac.webkit.org/changeset/137725
Note You need to log in before you can comment on or make changes to this bug.