Bug 104931

Summary: [GTK] Safeguard against possible NULL-dereference
Product: WebKit Reporter: Claudio Saavedra <csaavedra>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, jdiggs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104114    
Attachments:
Description Flags
Patch
none
Patch none

Claudio Saavedra
Reported 2012-12-13 10:18:18 PST
[GTK] Safeguard against possible NULL-dereference
Attachments
Patch (1.53 KB, patch)
2012-12-13 10:19 PST, Claudio Saavedra 		no flags
DetailsFormatted DiffDiff
Patch (1.84 KB, patch)
2013-01-16 04:24 PST, Claudio Saavedra 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Claudio Saavedra
Comment 1 2012-12-13 10:19:56 PST
Created attachment 179298 [details] Patch
WebKit Review Bot
Comment 2 2012-12-13 11:52:52 PST
Comment on attachment 179298 [details] Patch Clearing flags on attachment: 179298 Committed r137633: <http://trac.webkit.org/changeset/137633>
WebKit Review Bot
Comment 3 2012-12-13 11:52:55 PST
All reviewed patches have been landed. Closing bug.
Claudio Saavedra
Comment 4 2013-01-16 04:14:05 PST
The patch is actually broken as it doesn't let the other cases be handled. I'll attach a sane version now, sorry for this.
Claudio Saavedra
Comment 5 2013-01-16 04:24:28 PST
Created attachment 182959 [details] Patch
Martin Robinson
Comment 6 2013-01-16 06:17:15 PST
Comment on attachment 182959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182959&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:412 > - if (!parent) > - return -1; > - > if (!parent && isRootObject(coreObject)) { > AtkObject* atkParent = atkParentOfRootObject(object); > if (!atkParent) Looks good to me, but I'd like Joanie or Mario to do an unofficial review here.
Joanmarie Diggs
Comment 7 2013-01-16 06:24:49 PST
(In reply to comment #6) > Looks good to me, but I'd like Joanie or Mario to do an unofficial review here. Looks good to me as well. Thanks for doing it Claudio!!
WebKit Review Bot
Comment 8 2013-01-16 10:01:42 PST
Comment on attachment 182959 [details] Patch Clearing flags on attachment: 182959 Committed r139890: <http://trac.webkit.org/changeset/139890>
WebKit Review Bot
Comment 9 2013-01-16 10:01:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.