Bug 104925

Summary: Text Autosizing: Don't autosize unwrappable blocks
Product: WebKit Reporter: John Mellor <johnme>
Component: Layout and RenderingAssignee: John Mellor <johnme>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jchaffraix, kenneth, ojan.autocc, timvolodine, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84186    
Attachments:
Description Flags
Patch
none
Patch none

John Mellor
Reported 2012-12-13 09:25:24 PST
Text Autosizing: Don't autosize unwrappable blocks
Attachments
Patch (15.66 KB, patch)
2012-12-13 09:31 PST, John Mellor 		no flags
DetailsFormatted DiffDiff
Patch (15.67 KB, patch)
2012-12-14 03:40 PST, John Mellor 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
John Mellor
Comment 1 2012-12-13 09:31:57 PST
Created attachment 179287 [details] Patch
John Mellor
Comment 2 2012-12-13 09:32:58 PST
Kenneth/Julien, does this look good?
John Mellor
Comment 3 2012-12-13 10:17:37 PST
By the way, I tested this on 2000 popular homepages and the results were overwhelmingly positive. In particular it fixes a nasty issue on newegg.com where the font size of a div toggle between autosized and non-autosized everytime there is a layout (i.e. several times while the page incrementally renders, and every time you hover over a menu item) - http://crbug.com/165922
Julien Chaffraix
Comment 4 2012-12-13 15:11:43 PST
Comment on attachment 179287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179287&action=review > Source/WebCore/ChangeLog:19 > + Use containerShouldbeAutosized instead of contentHeightIsConstrained| Not sure why you put a '|' at the end of your sentence, but AFAICT English uses a '.' :) > Source/WebCore/ChangeLog:25 > + Use containerShouldbeAutosized instead of contentHeightIsConstrained| Ditto. > Source/WebCore/ChangeLog:27 > + Declared containerShouldbeAutosized Missing final dot.
Kenneth Rohde Christiansen
Comment 5 2012-12-13 23:36:10 PST
Looks fine to me, except the | thing Julien pointed out.
John Mellor
Comment 6 2012-12-14 03:40:40 PST
Created attachment 179465 [details] Patch
John Mellor
Comment 7 2012-12-14 03:41:26 PST
Comment on attachment 179465 [details] Patch Carrying forward reviews above.
WebKit Review Bot
Comment 8 2012-12-14 03:59:41 PST
Comment on attachment 179465 [details] Patch Clearing flags on attachment: 179465 Committed r137738: <http://trac.webkit.org/changeset/137738>
WebKit Review Bot
Comment 9 2012-12-14 03:59:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.