| Summary: | Text Autosizing: Don't autosize unwrappable blocks | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | John Mellor <johnme> | ||||||
| Component: | Layout and Rendering | Assignee: | John Mellor <johnme> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric, jchaffraix, kenneth, ojan.autocc, timvolodine, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 84186 | ||||||||
| Attachments: |
|
||||||||
|
Description
John Mellor
2012-12-13 09:25:24 PST
Created attachment 179287 [details]
Patch
Kenneth/Julien, does this look good? By the way, I tested this on 2000 popular homepages and the results were overwhelmingly positive. In particular it fixes a nasty issue on newegg.com where the font size of a div toggle between autosized and non-autosized everytime there is a layout (i.e. several times while the page incrementally renders, and every time you hover over a menu item) - http://crbug.com/165922 Comment on attachment 179287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179287&action=review > Source/WebCore/ChangeLog:19 > + Use containerShouldbeAutosized instead of contentHeightIsConstrained| Not sure why you put a '|' at the end of your sentence, but AFAICT English uses a '.' :) > Source/WebCore/ChangeLog:25 > + Use containerShouldbeAutosized instead of contentHeightIsConstrained| Ditto. > Source/WebCore/ChangeLog:27 > + Declared containerShouldbeAutosized Missing final dot. Looks fine to me, except the | thing Julien pointed out. Created attachment 179465 [details]
Patch
Comment on attachment 179465 [details]
Patch
Carrying forward reviews above.
Comment on attachment 179465 [details] Patch Clearing flags on attachment: 179465 Committed r137738: <http://trac.webkit.org/changeset/137738> All reviewed patches have been landed. Closing bug. |