Bug 104899

Summary: Web Inspector: Network: display JavaScript stack in case of script initiator.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, caseq, eustas, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 104992    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Screenshot
none
Patch pfeldman: review-

Eugene Klyuchnikov
Reported 2012-12-13 03:41:48 PST
We could either display it on hover or in a separate Network tab. RE: It would also be awesome if the stack trace was clickable back to the javascript sources, in the sources panel. Original issue: http://code.google.com/p/chromium/issues/detail?id=155300
Attachments
Patch (5.44 KB, patch)
2012-12-14 00:26 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Screenshot (38.26 KB, image/png)
2012-12-14 01:57 PST, Eugene Klyuchnikov 		no flags
Details
Patch (5.88 KB, patch)
2012-12-14 01:59 PST, Eugene Klyuchnikov 		pfeldman: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2012-12-14 00:26:30 PST
Created attachment 179438 [details] Patch
Pavel Feldman
Comment 2 2012-12-14 00:50:33 PST
A screenshot please?
Vsevolod Vlasov
Comment 3 2012-12-14 00:52:31 PST
Is it clickable? The timeline popover is not clickable right now.
Eugene Klyuchnikov
Comment 4 2012-12-14 01:57:37 PST
Created attachment 179450 [details] Screenshot
Eugene Klyuchnikov
Comment 5 2012-12-14 01:59:06 PST
Created attachment 179451 [details] Patch Use-standard-timeout
Pavel Feldman
Comment 6 2012-12-14 02:00:15 PST
Comment on attachment 179451 [details] Patch We want almost instant feedback here.
Vsevolod Vlasov
Comment 7 2012-12-14 02:04:32 PST
I think it should appear almost immediately, but disappear after a longer timeout.
Pavel Feldman
Comment 8 2012-12-14 02:13:18 PST
(In reply to comment #7) > I think it should appear almost immediately, but disappear after a longer timeout. As of today, Popover is designed in a way that the timeout before showing popover must be bigger than the one for hiding it. Changing it will require some popover rework. But we could try doing that.
Vsevolod Vlasov
Comment 9 2012-12-17 03:52:56 PST
Comment on attachment 179438 [details] Patch We should either support show timeout being shorter than hide timeout or use different popover helper for initiator. This implementation is not clickable which does not make much sense to me.
Eugene Klyuchnikov
Comment 10 2012-12-18 01:35:13 PST
Comment on attachment 179438 [details] Patch Popover behavior has been changed. PTAL
WebKit Review Bot
Comment 11 2012-12-18 02:04:25 PST
Comment on attachment 179438 [details] Patch Clearing flags on attachment: 179438 Committed r138000: <http://trac.webkit.org/changeset/138000>
WebKit Review Bot
Comment 12 2012-12-18 02:04:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.