Bug 104871

Summary: webkitpy: rename ResultSummary
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, tmpsantos, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103824    
Attachments:
Description Flags
Patch eric: review+

Dirk Pranke
Reported 2012-12-12 18:40:06 PST
webkitpy: rename ResultSummary
Attachments
Patch (65.65 KB, patch)
2012-12-12 18:46 PST, Dirk Pranke 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-12-12 18:46:46 PST
Created attachment 179179 [details] Patch
Eric Seidel (no email)
Comment 2 2012-12-12 19:26:13 PST
Comment on attachment 179179 [details] Patch LGTM.
Dirk Pranke
Comment 3 2012-12-13 11:06:53 PST
Committed r137621: <http://trac.webkit.org/changeset/137621>
Thiago Marcos P. Santos
Comment 4 2012-12-13 12:01:29 PST
Bots are failing with this: AttributeError raised: 'RunDetails' object has no attribute 'run_results' Traceback (most recent call last): File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 410, in main bot_printer.print_results(run_details) File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py", line 51, in print_results self.print_run_results(run_details.run_results) AttributeError: 'RunDetails' object has no attribute 'run_results' Failed to execute Tools/Scripts/new-run-webkit-tests at ./Tools/Scripts/run-webkit-tests line 126.
Dirk Pranke
Comment 5 2012-12-13 12:09:44 PST
Yeah, sorry. Fixed in http://trac.webkit.org/changeset/137634 (missed one variable rename; the patch adds a test for it).
Note You need to log in before you can comment on or make changes to this bug.