Bug 104868

Summary: [Resource Timing] Don't report resources with data: urls
Product: WebKit Reporter: James Simonsen <simonjam>
Component: New BugsAssignee: James Simonsen <simonjam>
Status: RESOLVED FIXED    
Severity: Normal CC: japhet, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

James Simonsen
Reported 2012-12-12 17:49:24 PST
[Resource Timing] Don't report resources with data: urls
Attachments
Patch (4.79 KB, patch)
2012-12-12 17:49 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.89 KB, patch)
2012-12-13 15:21 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Simonsen
Comment 1 2012-12-12 17:49:51 PST
Created attachment 179165 [details] Patch
Tony Gentilcore
Comment 2 2012-12-13 12:20:42 PST
Comment on attachment 179165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179165&action=review > Source/WebCore/loader/cache/CachedResourceLoader.cpp:709 > + if (resource && !resource->errorOccurred() && !resource->wasCanceled() && resource->response().isHTTP()) { Does this include HTTPS as well?
James Simonsen
Comment 3 2012-12-13 13:58:15 PST
(In reply to comment #2) > (From update of attachment 179165 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179165&action=review > > > Source/WebCore/loader/cache/CachedResourceLoader.cpp:709 > > + if (resource && !resource->errorOccurred() && !resource->wasCanceled() && resource->response().isHTTP()) { > > Does this include HTTPS as well? Yep.
James Simonsen
Comment 4 2012-12-13 15:21:40 PST
Created attachment 179353 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-12-13 16:14:23 PST
Comment on attachment 179353 [details] Patch for landing Clearing flags on attachment: 179353 Committed r137677: <http://trac.webkit.org/changeset/137677>
WebKit Review Bot
Comment 6 2012-12-13 16:14:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.