Bug 104863

Summary: Check whether a touchDown lands on a registered touch event handler from the compositor
Product: WebKit Reporter: yusufo
Component: New BugsAssignee: yusufo
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, dglazkov, fishd, jamesr, leviw, tkent+wkapi, webkit.review.bot, yusufo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch jamesr: review+, webkit.review.bot: commit-queue-

yusufo
Reported 2012-12-12 17:05:15 PST
Check whether a touchDown lands on a registered touch event handler from the compositor
Attachments
Patch (3.53 KB, patch)
2012-12-12 17:18 PST, yusufo
no flags
Patch (2.65 KB, patch)
2012-12-12 17:49 PST, yusufo
no flags
Patch (3.36 KB, patch)
2012-12-12 17:52 PST, yusufo
no flags
Patch (3.36 KB, patch)
2012-12-12 18:32 PST, yusufo
jamesr: review+
webkit.review.bot: commit-queue-
yusufo
Comment 1 2012-12-12 17:18:32 PST
WebKit Review Bot
Comment 2 2012-12-12 17:21:34 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
James Robinson
Comment 3 2012-12-12 17:25:02 PST
Comment on attachment 179156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179156&action=review > Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:61 > + MOCK_METHOD1(haveTouchEventHandslersAt, bool(WebPoint)); you don't need to add this unless you're adding a test that uses the mock, FYI
WebKit Review Bot
Comment 4 2012-12-12 17:40:43 PST
Comment on attachment 179156 [details] Patch Attachment 179156 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15311031
yusufo
Comment 5 2012-12-12 17:49:40 PST
yusufo
Comment 6 2012-12-12 17:52:10 PST
yusufo
Comment 7 2012-12-12 17:54:15 PST
I (In reply to comment #3) > (From update of attachment 179156 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179156&action=review > > > Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:61 > > + MOCK_METHOD1(haveTouchEventHandslersAt, bool(WebPoint)); > > you don't need to add this unless you're adding a test that uses the mock, FYI I just realized I need it because I am adding that function to WebInputHandlerClient as a pure virtual. I had misspelled the function name before.
James Robinson
Comment 8 2012-12-12 17:54:57 PST
Comment on attachment 179167 [details] Patch Ah indeed. R still = me
yusufo
Comment 9 2012-12-12 18:32:15 PST
James Robinson
Comment 10 2012-12-12 18:34:25 PST
Comment on attachment 179176 [details] Patch Seems like the same patch as before?
yusufo
Comment 11 2012-12-12 18:40:27 PST
Sorr(In reply to comment #10) > (From update of attachment 179176 [details]) > Seems like the same patch as before? Sorry the if was missing a !.
WebKit Review Bot
Comment 12 2012-12-13 10:25:39 PST
Comment on attachment 179176 [details] Patch Rejecting attachment 179176 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: commit-queue/Source/WebKit/chromium/third_party/v8-i18n --revision 159 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 52>At revision 159. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/15312322
James Robinson
Comment 13 2012-12-13 10:51:59 PST
ChangeLog has some minor issues - I'll fix and land by hand.
James Robinson
Comment 14 2012-12-13 10:53:53 PST
Note You need to log in before you can comment on or make changes to this bug.