Bug 104851

Summary:

Expose crypto.getRandomValues to Web Workers

Product:

WebKit

Reporter:

Ryan Sleevi <rsleevi>

Component:

WebCore Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, adam, ap, bfulgham, commit-queue, ggaren, haraken, jiewen_tan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

160880

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews121 for ios-simulator-elcapitan-wk2	none
Patch	darin: review+
Patch for landing	none

Ryan Sleevi

Reported 2012-12-12 15:07:13 PST

As per the latest W3C Web Crypto Editor's Draft, window.crypto.getRandomValues should be exposed to workers via the WorkerCrypto interface - http://dvcs.w3.org/hg/webcrypto-api/raw-file/f5e8d9a3e18f/spec/Overview.html#WorkerCrypto-interface

Attachments
Patch (35.66 KB, patch) 2016-08-12 16:50 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews121 for ios-simulator-elcapitan-wk2 (708.01 KB, application/zip) 2016-08-12 17:55 PDT, Build Bot	no flags	Details
Patch (37.29 KB, patch) 2016-08-12 18:12 PDT, Jiewen Tan	darin: review+	Details Formatted Diff Diff
Patch for landing (37.40 KB, patch) 2016-08-15 12:03 PDT, Jiewen Tan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2013-11-02 10:37:22 PDT

It doesn't look like Ryan is working on this, unassigning.

Adam Lippai

Comment 2 2016-07-11 06:06:35 PDT

With the FF48 release Safari is the last browser not supporting WebCrypto in web workers.

Radar WebKit Bug Importer

Comment 3 2016-07-11 14:28:47 PDT

<rdar://problem/27285714>

Jiewen Tan

Comment 4 2016-07-11 14:29:18 PDT

Being imported to radar for better task management.

Jiewen Tan

Comment 5 2016-08-12 16:50:45 PDT

Created attachment 285979 [details] Patch

Build Bot

Comment 6 2016-08-12 17:55:18 PDT

Comment on attachment 285979 [details] Patch Attachment 285979 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1860947 New failing tests: js/dom/global-constructors-attributes-dedicated-worker.html

Build Bot

Comment 7 2016-08-12 17:55:21 PDT

Created attachment 285986 [details] Archive of layout-test-results from ews121 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5

Jiewen Tan

Comment 8 2016-08-12 18:12:16 PDT

Created attachment 285989 [details] Patch

Darin Adler

Comment 9 2016-08-14 14:48:57 PDT

Comment on attachment 285989 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285989&action=review > Source/WebCore/page/Crypto.idl:32 > + GenerateIsReachable=ImplScriptExecutionContext, > + Exposed=(Window,Worker), Please keep these in alphabetical order. > Source/WebCore/workers/WorkerGlobalScope.h:153 > + Crypto* crypto() const; Please change this to return a reference instead of a pointer. > Source/WebCore/workers/WorkerGlobalScope.h:201 > + mutable RefPtr<Crypto> m_crypto; Extra space here; please remove that.

Jiewen Tan

Comment 10 2016-08-15 11:55:55 PDT

Comment on attachment 285989 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285989&action=review Thanks Darin for reviewing my patch. >> Source/WebCore/page/Crypto.idl:32 >> + Exposed=(Window,Worker), > > Please keep these in alphabetical order. Fixed. >> Source/WebCore/workers/WorkerGlobalScope.h:153 >> + Crypto* crypto() const; > > Please change this to return a reference instead of a pointer. Fixed. >> Source/WebCore/workers/WorkerGlobalScope.h:201 >> + mutable RefPtr<Crypto> m_crypto; > > Extra space here; please remove that. Fixed.

Jiewen Tan

Comment 11 2016-08-15 12:03:35 PDT

Created attachment 286073 [details] Patch for landing

WebKit Commit Bot

Comment 12 2016-08-15 14:10:05 PDT

Comment on attachment 286073 [details] Patch for landing Clearing flags on attachment: 286073 Committed r204481: <http://trac.webkit.org/changeset/204481>

Note You need to log in before you can comment on or make changes to this bug.