Bug 104843

Summary: Have kFixedPointDenominator be constant across ports
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, cmarcelo, d-r, eric, gyuyoung.kim, hausmann, jchaffraix, kenneth, laszlo.gombos, macpherson, menard, ojan.autocc, ossy, ostap73, pnormand, rakuco, simon.fraser, webkit.review.bot, xan.lopez, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104788    
Attachments:
Description Flags
Patch
jchaffraix: review+, jchaffraix: commit-queue-
Patch for landing none

Emil A Eklund
Reported 2012-12-12 14:17:27 PST
Currently the kFixedPointDenominator constant is set to either 64 or 1 depending on the SUBPIXEL_LAYOUT flag. As this constant is used to limit the range of supported values this results in inconsistencies across ports. By changing kFixedPointDenominator to always be 64 and introducing a new constant (kEffectiveFixedPointDenominator) that varies we can ensure that the same range of values are supported across ports regardless of the SUBPIXEL_LAYOUT flag.
Attachments
Patch (18.30 KB, patch)
2012-12-12 14:26 PST, Emil A Eklund 		jchaffraix: review+
jchaffraix: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (16.69 KB, patch)
2012-12-17 15:21 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-12-12 14:26:06 PST
Created attachment 179126 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-12-17 02:04:48 PST
Comment on attachment 179126 [details] Patch I'm fine with this from an EFL point of view.
Julien Chaffraix
Comment 3 2012-12-17 13:25:58 PST
CC'ing some more Gtk and Qt people as this will cause a tiny change on their port but it's a platform alignment so really an FYI.
Julien Chaffraix
Comment 4 2012-12-17 14:08:34 PST
Comment on attachment 179126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179126&action=review r=me, but let's give the port maintainer some time to comment if there is something we missed. > Source/WebCore/ChangeLog:22 > + Change to clamp and then round. As discussed, I would just not do this change as it's unrelated. Next time, please explain 'why' you did that instead of having me guess what was the intent.
Emil A Eklund
Comment 5 2012-12-17 15:21:07 PST
Created attachment 179812 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-12-18 08:46:09 PST
Comment on attachment 179812 [details] Patch for landing Clearing flags on attachment: 179812 Committed r138026: <http://trac.webkit.org/changeset/138026>
WebKit Review Bot
Comment 7 2012-12-18 08:46:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.