Bug 104839

Summary: build-webkit --chromium-android forces Make even when update-webkit used --ninja
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, dpranke, peter, thakis, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2012-12-12 13:47:04 PST
build-webkit --chromium-android forces Make even when update-webkit used --ninja
Attachments
Patch (1.60 KB, patch)
2012-12-12 13:48 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-12-12 13:48:23 PST
Created attachment 179120 [details] Patch
Nico Weber
Comment 2 2012-12-12 13:50:59 PST
lgtm, but I'm not an reviewer.
Eric Seidel (no email)
Comment 3 2012-12-12 13:51:21 PST
This is mostly just reverting http://trac.webkit.org/changeset/124219, and thus should be reviewed by Peter.
Nico Weber
Comment 4 2012-12-12 13:52:34 PST
Peter lgtm'd this in https://bugs.webkit.org/show_bug.cgi?id=104434#c4
Eric Seidel (no email)
Comment 5 2012-12-12 13:54:59 PST
(In reply to comment #4) > Peter lgtm'd this in https://bugs.webkit.org/show_bug.cgi?id=104434#c4 Very true. But I'd like to have him do it again. :) Then he can be on the hook when his Android bots break. :) I'll let him r+ and cq+ this while I sleep tonight :)
Tony Chang
Comment 6 2012-12-12 14:02:35 PST
Comment on attachment 179120 [details] Patch Peter's not a reviewer. I'll r+ and Peter can cq+ or cq- when he sees this.
Peter Beverloo
Comment 7 2012-12-13 10:17:52 PST
Comment on attachment 179120 [details] Patch Thanks Eric! Verified that it starts using Ninja locally.
WebKit Review Bot
Comment 8 2012-12-13 10:35:54 PST
Comment on attachment 179120 [details] Patch Clearing flags on attachment: 179120 Committed r137611: <http://trac.webkit.org/changeset/137611>
WebKit Review Bot
Comment 9 2012-12-13 10:35:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.