Summary: | build-webkit --chromium-android forces Make even when update-webkit used --ninja | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dbates, dpranke, peter, thakis, tony, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2012-12-12 13:47:04 PST
Created attachment 179120 [details]
Patch
lgtm, but I'm not an reviewer. This is mostly just reverting http://trac.webkit.org/changeset/124219, and thus should be reviewed by Peter. Peter lgtm'd this in https://bugs.webkit.org/show_bug.cgi?id=104434#c4 (In reply to comment #4) > Peter lgtm'd this in https://bugs.webkit.org/show_bug.cgi?id=104434#c4 Very true. But I'd like to have him do it again. :) Then he can be on the hook when his Android bots break. :) I'll let him r+ and cq+ this while I sleep tonight :) Comment on attachment 179120 [details]
Patch
Peter's not a reviewer. I'll r+ and Peter can cq+ or cq- when he sees this.
Comment on attachment 179120 [details]
Patch
Thanks Eric! Verified that it starts using Ninja locally.
Comment on attachment 179120 [details] Patch Clearing flags on attachment: 179120 Committed r137611: <http://trac.webkit.org/changeset/137611> All reviewed patches have been landed. Closing bug. |