Bug 104823

Summary: [BlackBerry] Clean up log output in WebKit/blackberry
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: WebKit BlackBerryAssignee: Jakob Petsovits <jpetsovits>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, manyoso, mifenton, nima.ghanavatian, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Slightly better patch none

Jakob Petsovits
Reported 2012-12-12 10:10:44 PST
Log output is a minor mess right now. The worst thing is that we use the BBLOG() macro for logs that are already covered by a preprocessor define, but there are also consistency issues with namespace usage and point/size/rect output formats, compiler warnings, unnecessary newlines, parameter indentation that would never pass stylebot checks, and even a build error for a debug block that's defined out and hasn't been updated to reflect current WebCore API. It's getting on my nerves to have to adjust the logging code every time I enable it, and then keep it out of the resulting patches because it's not logically related. It's time to fix logging for good. Patch below.
Attachments
Patch (82.10 KB, patch)
2012-12-12 11:25 PST, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Slightly better patch (83.74 KB, patch)
2012-12-12 11:33 PST, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2012-12-12 11:25:52 PST
Created attachment 179088 [details] Patch
Jakob Petsovits
Comment 2 2012-12-12 11:28:22 PST
Comment on attachment 179088 [details] Patch Whoops, found two more missing Platform:: prefixes in Selection* and Input* log macros. Let's get these in too.
Jakob Petsovits
Comment 3 2012-12-12 11:33:03 PST
Created attachment 179089 [details] Slightly better patch
WebKit Review Bot
Comment 4 2012-12-17 12:01:05 PST
Comment on attachment 179089 [details] Slightly better patch Clearing flags on attachment: 179089 Committed r137929: <http://trac.webkit.org/changeset/137929>
WebKit Review Bot
Comment 5 2012-12-17 12:01:09 PST
All reviewed patches have been landed. Closing bug.
Nima Ghanavatian
Comment 6 2012-12-17 12:14:53 PST
*** Bug 105200 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.