Bug 104788 – REGRESSION (r137365): Three layout test failures on GTK, Qt, EFL

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Zan Dobersek]

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=css3%2Fflexbox%2Fflex-algorithm.html%2Cfast%2Fcss%2Flarge-number-round-trip.html%2Cfast%2Fcss%2Flarge-numbers.html
http://trac.webkit.org/changeset/137365

Here are the diffs (for the GTK port):
--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/css3/flexbox/flex-algorithm-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/css3/flexbox/flex-algorithm-actual.txt
@@ -12,7 +12,15 @@
 PASS
 PASS
 PASS
-PASS
+FAIL:
+Expected 0 for width, but got 600. 
+Expected 33554428 for width, but got 0. 
+
+<div class="flexbox">
+  <div data-expected-width="0" style="-webkit-flex: 100000000000000000000000000000000000000 0 600px; -moz-flex: 100000000000000000000000000000000000000 0 600px"></div>
+  <div data-expected-width="600" style="-webkit-flex: 0 100000000000000000000000000000000000000 600px; -moz-flex: 0 100000000000000000000000000000000000000 600px"></div>
+  <div data-expected-width="33554428" style="-webkit-flex: 1 1 100000000000000000000000000000000000000px; -moz-flex: 1 1 100000000000000000000000000000000000000px"></div>
+</div>
 PASS
 PASS
 PASS

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/css/large-number-round-trip-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/css/large-number-round-trip-actual.txt
@@ -1 +1,3 @@
 PASS: read 90010000px back as 90010000px, read again as 90010000px
+PASS: read -33554430px back as -33554430px, read again as -33554430px
+PASS: read -90010000px back as -90010000px, read again as -90010000px

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/css/large-numbers-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/css/large-numbers-actual.txt
@@ -6,11 +6,11 @@
 PASS element.width = 100000px, returns offsetWidth, rect.width and computed width as expected.
 PASS element.width = 1000000px, returns offsetWidth, rect.width and computed width as expected.
 PASS element.width = 10000000px, returns offsetWidth, rect.width and computed width as expected.
-PASS element.width = 100000000px, returns offsetWidth, rect.width and computed width as expected.
-PASS element.width = 1000000000px, returns offsetWidth, rect.width and computed width as expected.
-PASS element.width = 10000000000px, returns offsetWidth, rect.width and computed width as expected.
-PASS element.width = 100000000000px, returns offsetWidth, rect.width and computed width as expected.
-PASS element.width = 1000000000000px, returns offsetWidth, rect.width and computed width as expected.
+FAIL element.width = 100000000px, returns offsetWidth 100000000, rect.width 100000000 and computed width 100000000, expected 33554428.
+FAIL element.width = 1000000000px, returns offsetWidth 1000000000, rect.width 1000000000 and computed width 1000000000, expected 33554428.
+FAIL element.width = 10000000000px, returns offsetWidth 0, rect.width 0 and computed width 0, expected 33554428.
+FAIL element.width = 100000000000px, returns offsetWidth 0, rect.width 0 and computed width 0, expected 33554428.
+FAIL element.width = 1000000000000px, returns offsetWidth 0, rect.width 0 and computed width 0, expected 33554428.
 PASS element.width = 0px, returns offsetWidth, rect.width and computed width as expected.
 PASS element.width = -1px, returns offsetWidth, rect.width and computed width as expected.
 PASS element.width = -10px, returns offsetWidth, rect.width and computed width as expected.
@@ -31,11 +31,11 @@
 PASS element.left = 100000px, returns offsetLeft, rect.left and computed left as expected.
 PASS element.left = 1000000px, returns offsetLeft, rect.left and computed left as expected.
 PASS element.left = 10000000px, returns offsetLeft, rect.left and computed left as expected.
-PASS element.left = 100000000px, returns offsetLeft, rect.left and computed left as expected.
-PASS element.left = 1000000000px, returns offsetLeft, rect.left and computed left as expected.
-PASS element.left = 10000000000px, returns offsetLeft, rect.left and computed left as expected.
-PASS element.left = 100000000000px, returns offsetLeft, rect.left and computed left as expected.
-PASS element.left = 1000000000000px, returns offsetLeft, rect.left and computed left as expected.
+FAIL element.left = 100000000px, returns offsetLeft 100000000, rect.left 100000000 and computed left 100000000, expected 33554428.
+FAIL element.left = 1000000000px, returns offsetLeft 1000000000, rect.left 1000000000 and computed left 1000000000, expected 33554428.
+FAIL element.left = 10000000000px, returns offsetLeft -2147483648, rect.left -2147483648 and computed left 2147483648, expected 33554428.
+FAIL element.left = 100000000000px, returns offsetLeft -2147483648, rect.left -2147483648 and computed left 2147483648, expected 33554428.
+FAIL element.left = 1000000000000px, returns offsetLeft -2147483648, rect.left -2147483648 and computed left 2147483648, expected 33554428.
 PASS element.left = -1px, returns offsetLeft, rect.left and computed left as expected.
 PASS element.left = -10px, returns offsetLeft, rect.left and computed left as expected.
 PASS element.left = -100px, returns offsetLeft, rect.left and computed left as expected.
@@ -43,11 +43,11 @@
 PASS element.left = -100000px, returns offsetLeft, rect.left and computed left as expected.
 PASS element.left = -1000000px, returns offsetLeft, rect.left and computed left as expected.
 PASS element.left = -10000000px, returns offsetLeft, rect.left and computed left as expected.
-PASS element.left = -100000000px, returns offsetLeft, rect.left and computed left as expected.
-PASS element.left = -1000000000px, returns offsetLeft, rect.left and computed left as expected.
-PASS element.left = -10000000000px, returns offsetLeft, rect.left and computed left as expected.
-PASS element.left = -100000000000px, returns offsetLeft, rect.left and computed left as expected.
-PASS element.left = -1000000000000px, returns offsetLeft, rect.left and computed left as expected.
+FAIL element.left = -100000000px, returns offsetLeft -100000000, rect.left -100000000 and computed left -100000000, expected -33554430.
+FAIL element.left = -1000000000px, returns offsetLeft -1000000000, rect.left -1000000000 and computed left -1000000000, expected -33554430.
+FAIL element.left = -10000000000px, returns offsetLeft -2147483648, rect.left -2147483648 and computed left -2147483648, expected -33554430.
+FAIL element.left = -100000000000px, returns offsetLeft -2147483648, rect.left -2147483648 and computed left -2147483648, expected -33554430.
+FAIL element.left = -1000000000000px, returns offsetLeft -2147483648, rect.left -2147483648 and computed left -2147483648, expected -33554430.
 Test handling of numbers outside of the supported range.
 
 Properties may restrict numeric values to some range. If the value is outside the allowed range, the declaration is invalid and must be ignored. As per the CSS3 specification.

[Emil A Eklund]

These tests will need platform specific baselines until they turn on subpixel layout. I'll take care of it./

[Emil A Eklund]

Committed r138323: <http://trac.webkit.org/changeset/138323>