Bug 104781

Summary: [Qt] Fix linkage against SQLite
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, ossy, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Hausmann
Reported 2012-12-12 01:48:08 PST
[Qt] Fix linkage against SQLite
Attachments
Patch (4.50 KB, patch)
2012-12-12 01:50 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2012-12-12 01:50:38 PST
Created attachment 179002 [details] Patch
Csaba Osztrogonác
Comment 2 2012-12-12 02:39:15 PST
Comment on attachment 179002 [details] Patch LGTM, r=me.
Simon Hausmann
Comment 3 2012-12-12 02:55:58 PST
Committed r137444: <http://trac.webkit.org/changeset/137444>
Csaba Osztrogonác
Comment 4 2012-12-12 03:16:54 PST
(In reply to comment #3) > Committed r137444: <http://trac.webkit.org/changeset/137444> It broke the Mac build: ------------------------ Project ERROR: WebKit requires SQLite. Either make it available via pkg-config, set $SQLITE3SRCDIR or build WebKit under qt5.git. I have no idea why, and I can't debug it without Mac build environment. and the ARM build: ------------------- Failed to set up build environment using qmake! Project ERROR: WebKit requires SQLite. Either make it available via pkg-config, set $SQLITE3SRCDIR or build WebKit under qt5.git. Hmmm ... It is the non-pkg-config (default for cross compiling), non-qt5.git and system sqlite installed case.
Simon Hausmann
Comment 5 2012-12-12 03:31:34 PST
Mac fix landed in http://trac.webkit.org/changeset/137446 *crossing fingers*
Csaba Osztrogonác
Comment 6 2012-12-12 04:58:58 PST
(In reply to comment #5) > Mac fix landed in http://trac.webkit.org/changeset/137446 *crossing fingers* And a typo fixed in http://trac.webkit.org/changeset/137452
Note You need to log in before you can comment on or make changes to this bug.