Bug 104770 – REGRESSION(r137408): breaks chromium's browser tests which use WebKitShadowRoot (Requested by hayato on #webkit).

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Review Bot]

http://trac.webkit.org/changeset/137408 broke the build:
breaks chromium's browser tests which use WebKitShadowRoot (Requested by hayato on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 178976 [details]
ROLLOUT of r137408

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[WebKit Review Bot]

Comment on attachment 178976 [details]
ROLLOUT of r137408

Rejecting attachment 178976 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
rame.html
patching file LayoutTests/fast/js/global-constructors-expected.txt
patching file LayoutTests/inspector/elements/shadow-root.html
patching file LayoutTests/inspector/elements/update-shadowdom.html
patching file LayoutTests/platform/efl/fast/js/global-constructors-expected.txt
patching file LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15281379

[Hayato Ito]

It seems http://trac.webkit.org/changeset/137421 depends on the r137408.

So instead of rolling out the this big patch, it might be reasonable to just recover the constructor part so that we can avoid reverting all existing layout tests.
Let me do that.

(In reply to comment #2)
> (From update of attachment 178976 [details])
> Rejecting attachment 178976 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2
> 
> Last 500 characters of output:
> rame.html
> patching file LayoutTests/fast/js/global-constructors-expected.txt
> patching file LayoutTests/inspector/elements/shadow-root.html
> patching file LayoutTests/inspector/elements/update-shadowdom.html
> patching file LayoutTests/platform/efl/fast/js/global-constructors-expected.txt
> patching file LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt
> 
> Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue
> 
> Full output: http://queues.webkit.org/results/15281379

[Hayato Ito]

Committed r137425: <http://trac.webkit.org/changeset/137425>