Summary: | Copying text with ruby inserts new lines around rt elements | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||
Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | adele, dglazkov, enrica, kojii, mifenton, mitz, rolandsteiner, webkit-bug-importer, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2012-12-11 22:01:02 PST
Created attachment 178964 [details]
Patch
Created attachment 178966 [details]
Patch
Comment on attachment 178966 [details]
Patch
Thanks for the review! I’m excited to fix this bug.
Comment on attachment 178966 [details] Patch Rejecting attachment 178966 [details] from commit-queue. New failing tests: fast/ruby/after-doesnt-crash.html fast/ruby/rubyDOM-insert-rt-block-1.html fast/ruby/rubyDOM-remove-rt-block-3.html fast/ruby/rubyDOM-remove-rt-block-2.html fast/ruby/ruby-text-indent.html fast/ruby/before-doesnt-crash.html fast/ruby/ruby-line-height.html fast/ruby/rubyDOM-insert-rt-block-3.html fast/ruby/text-emphasis.html fast/ruby/parse-rp.html fast/ruby/rubyDOM-remove-rt-block-1.html fast/block/line-layout/selection-highlight-crash.html fast/ruby/rubyDOM-insert-rt-block-2.html Full output: http://queues.webkit.org/results/15278445 Oh oops, I forgot that my patch also affects innerText & DRT results. Will rebaseline them before landing it. Comment on attachment 178966 [details] Patch Attachment 178966 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15272644 New failing tests: fast/ruby/after-doesnt-crash.html fast/ruby/rubyDOM-insert-rt-block-1.html fast/ruby/rubyDOM-remove-rt-block-3.html fast/ruby/rubyDOM-remove-rt-block-2.html fast/ruby/ruby-text-indent.html fast/ruby/before-doesnt-crash.html fast/ruby/ruby-line-height.html fast/ruby/rubyDOM-insert-rt-block-3.html fast/ruby/text-emphasis.html fast/ruby/parse-rp.html fast/ruby/rubyDOM-remove-rt-block-1.html fast/block/line-layout/selection-highlight-crash.html fast/ruby/rubyDOM-insert-rt-block-2.html Created attachment 178999 [details]
Patch for landing
Comment on attachment 178999 [details] Patch for landing Attachment 178999 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15276604 New failing tests: fast/block/line-layout/selection-highlight-crash.html Committed r137477: <http://trac.webkit.org/changeset/137477> |