Bug 104765

Summary:

Copying text with ruby inserts new lines around rt elements

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

New Bugs

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele, dglazkov, enrica, kojii, mifenton, mitz, rolandsteiner, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	webkit.review.bot: commit-queue-

Ryosuke Niwa

Reported 2012-12-11 22:01:02 PST

Copying text with ruby inserts new lines around rt elements

Attachments
Patch (4.82 KB, patch) 2012-12-11 22:06 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Patch (7.29 KB, patch) 2012-12-11 22:21 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Patch for landing (13.03 KB, patch) 2012-12-12 01:42 PST, Ryosuke Niwa	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2012-12-11 22:06:12 PST

Created attachment 178964 [details] Patch

Ryosuke Niwa

Comment 2 2012-12-11 22:08:07 PST

<rdar://problem/12715037>

Ryosuke Niwa

Comment 3 2012-12-11 22:21:13 PST

Created attachment 178966 [details] Patch

Ryosuke Niwa

Comment 4 2012-12-11 22:23:48 PST

Comment on attachment 178966 [details] Patch Thanks for the review! I’m excited to fix this bug.

WebKit Review Bot

Comment 5 2012-12-11 23:16:08 PST

Comment on attachment 178966 [details] Patch Rejecting attachment 178966 [details] from commit-queue. New failing tests: fast/ruby/after-doesnt-crash.html fast/ruby/rubyDOM-insert-rt-block-1.html fast/ruby/rubyDOM-remove-rt-block-3.html fast/ruby/rubyDOM-remove-rt-block-2.html fast/ruby/ruby-text-indent.html fast/ruby/before-doesnt-crash.html fast/ruby/ruby-line-height.html fast/ruby/rubyDOM-insert-rt-block-3.html fast/ruby/text-emphasis.html fast/ruby/parse-rp.html fast/ruby/rubyDOM-remove-rt-block-1.html fast/block/line-layout/selection-highlight-crash.html fast/ruby/rubyDOM-insert-rt-block-2.html Full output: http://queues.webkit.org/results/15278445

Ryosuke Niwa

Comment 6 2012-12-11 23:34:27 PST

Oh oops, I forgot that my patch also affects innerText & DRT results. Will rebaseline them before landing it.

WebKit Review Bot

Comment 7 2012-12-12 00:06:58 PST

Comment on attachment 178966 [details] Patch Attachment 178966 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15272644 New failing tests: fast/ruby/after-doesnt-crash.html fast/ruby/rubyDOM-insert-rt-block-1.html fast/ruby/rubyDOM-remove-rt-block-3.html fast/ruby/rubyDOM-remove-rt-block-2.html fast/ruby/ruby-text-indent.html fast/ruby/before-doesnt-crash.html fast/ruby/ruby-line-height.html fast/ruby/rubyDOM-insert-rt-block-3.html fast/ruby/text-emphasis.html fast/ruby/parse-rp.html fast/ruby/rubyDOM-remove-rt-block-1.html fast/block/line-layout/selection-highlight-crash.html fast/ruby/rubyDOM-insert-rt-block-2.html

Ryosuke Niwa

Comment 8 2012-12-12 01:42:33 PST

Created attachment 178999 [details] Patch for landing

WebKit Review Bot

Comment 9 2012-12-12 02:25:52 PST

Comment on attachment 178999 [details] Patch for landing Attachment 178999 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15276604 New failing tests: fast/block/line-layout/selection-highlight-crash.html

Ryosuke Niwa

Comment 10 2012-12-12 09:54:47 PST

Committed r137477: <http://trac.webkit.org/changeset/137477>

Note You need to log in before you can comment on or make changes to this bug.