Bug 104747

Summary: [CSS Grid Layout] Implement CSS parsing and handling for min-content and max-content
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, macpherson, menard, ojan.autocc, ojan, tony, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 104125    
Attachments:
Description Flags
Proposed parsing / style resolution extension. none

Julien Chaffraix
Reported 2012-12-11 17:22:58 PST
We currently don't allow min-content and max-content to be a <track-breadth> which is allowed by the specification. Per discussion with Ojan and Tony, we will use the prefixed version of min-content / max-content.
Attachments
Proposed parsing / style resolution extension. (19.90 KB, patch)
2012-12-11 18:00 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2012-12-11 18:00:09 PST
Created attachment 178936 [details] Proposed parsing / style resolution extension.
Alexis Menard (darktears)
Comment 2 2012-12-12 03:04:59 PST
Comment on attachment 178936 [details] Proposed parsing / style resolution extension. View in context: https://bugs.webkit.org/attachment.cgi?id=178936&action=review > LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js:141 > +element.style.webkitGridColumns = "minmax(-webkit-min-content, -webkit-max-content)"; You could also test the element.style return value in addition of the computed style. Just for the sake of it.
Julien Chaffraix
Comment 3 2012-12-12 09:23:50 PST
Comment on attachment 178936 [details] Proposed parsing / style resolution extension. View in context: https://bugs.webkit.org/attachment.cgi?id=178936&action=review >> LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js:141 >> +element.style.webkitGridColumns = "minmax(-webkit-min-content, -webkit-max-content)"; > > You could also test the element.style return value in addition of the computed style. Just for the sake of it. Very, very good catch. It seems that this is broken (as we have no coverage for that case). Per our discussion, I filed bug 104821 to track adding the coverage and fixing it.
WebKit Review Bot
Comment 4 2012-12-12 09:56:25 PST
Comment on attachment 178936 [details] Proposed parsing / style resolution extension. Clearing flags on attachment: 178936 Committed r137478: <http://trac.webkit.org/changeset/137478>
WebKit Review Bot
Comment 5 2012-12-12 09:56:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.