Bug 104714

Summary: Add window.internals.mainThreadScrollReasonsAsText for testing slow scrolling
Product: WebKit Reporter: Xianzhu Wang <wangxianzhu>
Component: Tools / TestsAssignee: Xianzhu Wang <wangxianzhu>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, eric, jamesr, simon.fraser, thorton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 102543    
Attachments:
Description Flags
Patch
none
Patch none

Xianzhu Wang
Reported 2012-12-11 13:43:46 PST
Bug 102543 is about slow scrolling caused by out-of-view fixed position elements. It needs a way to test if slow scrolling is triggered. This bug is to separate the patch to bug 102543 into smaller parts.
Attachments
Patch (13.75 KB, patch)
2012-12-11 13:51 PST, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
Patch (13.78 KB, patch)
2012-12-11 14:18 PST, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-12-11 13:51:16 PST
Created attachment 178867 [details] Patch
Eric Seidel (no email)
Comment 2 2012-12-11 14:06:58 PST
Comment on attachment 178867 [details] Patch LGTM.
Eric Seidel (no email)
Comment 3 2012-12-11 14:07:17 PST
Thank you for breaking this out, this should make your main patch even smaller and easier to understand.
WebKit Review Bot
Comment 4 2012-12-11 14:10:27 PST
Comment on attachment 178867 [details] Patch Rejecting attachment 178867 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15259689
Xianzhu Wang
Comment 5 2012-12-11 14:18:13 PST
Created attachment 178873 [details] Patch
WebKit Review Bot
Comment 6 2012-12-11 16:57:44 PST
Comment on attachment 178873 [details] Patch Clearing flags on attachment: 178873 Committed r137388: <http://trac.webkit.org/changeset/137388>
WebKit Review Bot
Comment 7 2012-12-11 16:57:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.