Summary: | [Texmap] Remove lowp/highp indicators as they're not needed with ANGLE. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||||||
Component: | New Bugs | Assignee: | Noam Rosenthal <noam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | jturcotte, kenneth, mrobinson, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Noam Rosenthal
2012-12-11 13:06:51 PST
Created attachment 178859 [details]
Patch
Comment on attachment 178859 [details] Patch Rejecting attachment 178859 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ed at 382 (offset 17 lines). Hunk #17 succeeded at 395 (offset 17 lines). Hunk #18 succeeded at 427 (offset 17 lines). Hunk #19 succeeded at 461 (offset 17 lines). Hunk #20 succeeded at 485 (offset 17 lines). 3 out of 20 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Martin Rob..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15285146 Created attachment 178987 [details]
Patch for landing
Comment on attachment 178987 [details] Patch for landing Rejecting attachment 178987 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15281404 Created attachment 179101 [details]
Patch
Comment on attachment 179101 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179101&action=review > Source/WebCore/ChangeLog:8 > + > + lowp/highp indicator were needed for GLES2, but ANGLE does not require them. What is the harm? I mean can you explain this better? (In reply to comment #6) > (From update of attachment 179101 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179101&action=review > > > Source/WebCore/ChangeLog:8 > > + > > + lowp/highp indicator were needed for GLES2, but ANGLE does not require them. > > What is the harm? I mean can you explain this better? It's code with very little benefit if any, that makes the shaders harder to read. Comment on attachment 179101 [details] Patch Clearing flags on attachment: 179101 Committed r137545: <http://trac.webkit.org/changeset/137545> All reviewed patches have been landed. Closing bug. |