Bug 104697

Summary: [chromium] Templated conversion from WebVector to Vector
Product: WebKit Reporter: Alec Flett <alecflett>
Component: WebKit APIAssignee: Alec Flett <alecflett>
Status: RESOLVED WONTFIX    
Severity: Normal CC: fishd, hans, jamesr, jsbell, jyasskin, ravi.kasibhatla
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alec Flett
Reported 2012-12-11 11:54:40 PST
Right now it's fairly tedious to manually convert a WebVector<T> to a Vector<U> darin suggests: --- Perhaps: template <typename C> copyTo(C* other); (^^^ Maybe the out param should be a reference instead to match WebKit style.) ---
Attachments
Patch (3.54 KB, patch)
2012-12-11 16:02 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alec Flett
Comment 1 2012-12-11 16:02:22 PST
Created attachment 178906 [details] Patch
Alec Flett
Comment 2 2012-12-11 16:03:35 PST
Here's a strawman per darin's suggestion. The reference made usage a little cleaner since WTF::Vector and std::vector are rarely passed around as pointers.
Alec Flett
Comment 3 2013-02-27 13:27:29 PST
Ended up dealing with this more efficiently with WebData / SharedBuffer
Eric Seidel (no email)
Comment 4 2013-03-01 02:48:29 PST
Comment on attachment 178906 [details] Patch Cleared review? from attachment 178906 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.