Bug 104691

Summary:

[WK2 NetworkProcess] DOM cookie access functions should respect private browsing

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebKit2

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, sam, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none
Patch	none
Patch	buildbot: commit-queue-
proposed patch	buildbot: commit-queue-
proposed patch	sam: review+, buildbot: commit-queue-
follow-up	andersca: review+

Alexey Proskuryakov

Reported 2012-12-11 11:26:04 PST

DOM cookie access functions should respect private browsing. <rdar://problem/12838354>

Attachments
proposed patch (27.60 KB, patch) 2012-12-11 11:33 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
Patch (21.91 KB, patch) 2012-12-11 17:17 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (21.91 KB, patch) 2012-12-11 18:22 PST, Sam Weinig	buildbot: commit-queue-	Details Formatted Diff Diff
proposed patch (28.46 KB, patch) 2012-12-13 11:59 PST, Alexey Proskuryakov	buildbot: commit-queue-	Details Formatted Diff Diff
proposed patch (28.46 KB, patch) 2012-12-13 12:53 PST, Alexey Proskuryakov	sam: review+ buildbot: commit-queue-	Details Formatted Diff Diff
follow-up (4.49 KB, patch) 2012-12-13 14:36 PST, Alexey Proskuryakov	andersca: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2012-12-11 11:33:54 PST

Created attachment 178841 [details] proposed patch

WebKit Review Bot

Comment 2 2012-12-11 11:36:44 PST

Attachment 178841 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:160: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2012-12-11 12:04:16 PST

Comment on attachment 178841 [details] proposed patch Attachment 178841 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15276326

Sam Weinig

Comment 4 2012-12-11 17:17:03 PST

Created attachment 178926 [details] Patch

WebKit Review Bot

Comment 5 2012-12-11 17:22:41 PST

Attachment 178926 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:160: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 6 2012-12-11 18:06:43 PST

Comment on attachment 178926 [details] Patch Attachment 178926 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15282266

Sam Weinig

Comment 7 2012-12-11 18:22:57 PST

Created attachment 178941 [details] Patch

WebKit Review Bot

Comment 8 2012-12-11 18:25:04 PST

Attachment 178941 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:160: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 9 2012-12-12 02:47:01 PST

Comment on attachment 178941 [details] Patch Attachment 178941 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15285236

Alexey Proskuryakov

Comment 10 2012-12-13 11:59:55 PST

Created attachment 179312 [details] proposed patch Sam's patch didn't include WebCore and WebKit1 changes.

WebKit Review Bot

Comment 11 2012-12-13 12:03:16 PST

Attachment 179312 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:159: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 12 2012-12-13 12:44:51 PST

Comment on attachment 179312 [details] proposed patch Attachment 179312 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15309381

Alexey Proskuryakov

Comment 13 2012-12-13 12:53:48 PST

Created attachment 179319 [details] proposed patch > 'WebCore/NotImplemnted.h': No such file or directory Indeed.

WebKit Review Bot

Comment 14 2012-12-13 12:58:48 PST

Attachment 179319 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:159: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 15 2012-12-13 13:23:01 PST

Comment on attachment 179319 [details] proposed patch Attachment 179319 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15319352

Alexey Proskuryakov

Comment 16 2012-12-13 13:46:11 PST

Oooh!!! So WebKit1 and WebKit2 on Windows share WebFrameNetworkingContext - the headers are separate, but since name and namespace are the same, and we have a single DLL, we are pulling the same implementation. Nonsense.

Alexey Proskuryakov

Comment 17 2012-12-13 13:49:19 PST

Committed <http://trac.webkit.org/changeset/137647>.

Alexey Proskuryakov

Comment 18 2012-12-13 14:32:20 PST

Oops, the patch was incomplete!

Alexey Proskuryakov

Comment 19 2012-12-13 14:36:07 PST

Created attachment 179337 [details] follow-up

Alexey Proskuryakov

Comment 20 2012-12-13 14:47:44 PST

Follow-up committed <http://trac.webkit.org/changeset/137657>.

Note You need to log in before you can comment on or make changes to this bug.