Summary: | Web inspector prints a warning about "Debug" not being localized | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Martin Robinson <mrobinson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, gtk-ews, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, xan.lopez, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Martin Robinson
2012-12-11 09:20:38 PST
Created attachment 178819 [details]
Patch
Comment on attachment 178819 [details] Patch Attachment 178819 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15260479 Comment on attachment 178819 [details] Patch Attachment 178819 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15242919 New failing tests: fast/frames/sandboxed-iframe-attribute-parsing.html svg/as-image/img-preserveAspectRatio-support-2.html I'm not sure if the GTK+ failure really relates to this patch, but I'll investigate further. I don't know how this could cause the tests listed to fail on Mac either. All I did was add a new localized string. Did you have a comment to attach to your r-? (In reply to comment #4) > I'm not sure if the GTK+ failure really relates to this patch, but I'll investigate further. I don't know how this could cause the tests listed to fail on Mac either. All I did was add a new localized string. Did you have a comment to attach to your r-? I'm pretty sure Pavel meant to r+ this. :) Comment on attachment 178819 [details] Patch Clearing flags on attachment: 178819 Committed r137430: <http://trac.webkit.org/changeset/137430> All reviewed patches have been landed. Closing bug. |