Bug 104668

Summary: [GTK] Soup network logs are frequently interrupted by other logging messages
Product: WebKit Reporter: Jonathon Jongsma (jonner) <jonathon>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: danw, gustavo, mrobinson, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
add custom soup log printer
none
fix nits none

Jonathon Jongsma (jonner)
Reported 2012-12-11 06:38:32 PST
The libsoup network logging should use the webkit logging infrastructure to print out network logging messages so that messages from all logging channels can be properly synchronized.
Attachments
add custom soup log printer (2.16 KB, patch)
2012-12-11 06:53 PST, Jonathon Jongsma (jonner) 		no flags
DetailsFormatted DiffDiff
fix nits (2.14 KB, patch)
2012-12-11 09:16 PST, Jonathon Jongsma (jonner) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathon Jongsma (jonner)
Comment 1 2012-12-11 06:53:31 PST
Created attachment 178793 [details] add custom soup log printer
Martin Robinson
Comment 2 2012-12-11 07:12:07 PST
Comment on attachment 178793 [details] add custom soup log printer View in context: https://bugs.webkit.org/attachment.cgi?id=178793&action=review Thanks! > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:81 > +inline static void soupLogPrinter(SoupLogger *logger, SoupLoggerLogLevel level, char direction, const char* data, gpointer userData) Nit: SoupLogger *logger should be SoupLogger* logger and you can omit the "userData" and "level" here entirely.
Jonathon Jongsma (jonner)
Comment 3 2012-12-11 09:16:41 PST
Created attachment 178818 [details] fix nits
WebKit Review Bot
Comment 4 2012-12-11 10:59:20 PST
Comment on attachment 178818 [details] fix nits Clearing flags on attachment: 178818 Committed r137337: <http://trac.webkit.org/changeset/137337>
WebKit Review Bot
Comment 5 2012-12-11 10:59:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.