Bug 104608

Summary: old-run-webkit-tests: add --show-results properly
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
fix bug number in comment
none
no need for the sub none

Dirk Pranke
Reported 2012-12-10 16:02:16 PST
old-run-webkit-tests: add --show-results properly
Attachments
Patch (1.71 KB, patch)
2012-12-10 16:03 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
fix bug number in comment (1.71 KB, patch)
2012-12-10 16:04 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
no need for the sub (1.70 KB, patch)
2012-12-10 16:07 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-12-10 16:03:04 PST
Created attachment 178657 [details] Patch
Dirk Pranke
Comment 2 2012-12-10 16:04:06 PST
Created attachment 178659 [details] fix bug number in comment
Eric Seidel (no email)
Comment 3 2012-12-10 16:05:36 PST
Comment on attachment 178659 [details] fix bug number in comment View in context: https://bugs.webkit.org/attachment.cgi?id=178659&action=review > Tools/Scripts/old-run-webkit-tests:362 > - 'show-results' => sub { $launchSafari = 1; }, > + 'show-results!' => sub { $launchSafari = $_[1]; }, You shouldn't need the sub to do this. :) Notice how sample-on-timeout works.
Dirk Pranke
Comment 4 2012-12-10 16:07:20 PST
Created attachment 178661 [details] no need for the sub
Dirk Pranke
Comment 5 2012-12-10 16:07:49 PST
You're right. Some days I just shouldn't be coding, apparently ...
Eric Seidel (no email)
Comment 6 2012-12-10 16:12:47 PST
Comment on attachment 178661 [details] no need for the sub LGTM.
WebKit Review Bot
Comment 7 2012-12-10 17:14:18 PST
Comment on attachment 178661 [details] no need for the sub Clearing flags on attachment: 178661 Committed r137228: <http://trac.webkit.org/changeset/137228>
WebKit Review Bot
Comment 8 2012-12-10 17:14:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.