Bug 104565 – run_webkit_tests throws exception when DRT is not present

• Component: Tools / Tests
• Status: RESOLVED FIXED

Unable to find test driver
    at /usr/local/google/home/eisinger/chrome/trunk/src/out/Debug/DumpRenderTree

For complete Linux build requirements, please see:

    http://code.google.com/p/chromium/wiki/LinuxBuildInstructions
Build check failed

TypeError raised: 'NoneType' object has no attribute '__getitem__'
Traceback (most recent call last):
  File "/usr/local/google/home/eisinger/chrome/trunk/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 432, in main
    bot_printer.print_results(run_details)
  File "/usr/local/google/home/eisinger/chrome/trunk/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py", line 52, in print_results
    self.print_unexpected_results(run_details.summarized_results)
  File "/usr/local/google/home/eisinger/chrome/trunk/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py", line 124, in print_unexpected_results
    resultsjsonparser.for_each_test(summarized_results['tests'], add_result)
TypeError: 'NoneType' object has no attribute '__getitem__'

[Dirk Pranke]

Created attachment 178597 [details]
Patch

[Dirk Pranke]

Committed r137189: <http://trac.webkit.org/changeset/137189>

[Eric Seidel (no email)]

I'm seeing:

[1132/1606] webkitpy.layout_tests.run_webkit_tests_integrationtest.MainTest.test_build_check failed:                          
  Traceback (most recent call last):
    File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 890, in test_build_check
      self.assertEqual(run_webkit_tests.main(['--platform', port_name, 'fast/harness/results.html'], out, err), -1)
    File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 419, in main
      port = host.port_factory.get(options.platform, options)
    File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 127, in get
      return cls(self._host, port_name, options=options, **kwargs)
    File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 77, in __init__
      assert self._version in self.SUPPORTED_OS_VERSIONS
  AssertionError
  
Ran 1606 tests in 2.998s    

on my linux box.  I suspect that may be related to this?

[Dirk Pranke]

(In reply to comment #3)
> I'm seeing:
> 
> [1132/1606] webkitpy.layout_tests.run_webkit_tests_integrationtest.MainTest.test_build_check failed:                          
>   Traceback (most recent call last):
>     File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 890, in test_build_check
>       self.assertEqual(run_webkit_tests.main(['--platform', port_name, 'fast/harness/results.html'], out, err), -1)
>     File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 419, in main
>       port = host.port_factory.get(options.platform, options)
>     File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 127, in get
>       return cls(self._host, port_name, options=options, **kwargs)
>     File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 77, in __init__
>       assert self._version in self.SUPPORTED_OS_VERSIONS
>   AssertionError
> 
> Ran 1606 tests in 2.998s    
> 
> on my linux box.  I suspect that may be related to this?

argh, yes. will fix shortly ...

[Dirk Pranke]

fix posted in https://bugs.webkit.org/show_bug.cgi?id=104589