Bug 104537 – [chromium] Move the test implementation of WebKit::WebPlugin to the TestRunner library

• Component: New Bugs
• Status: RESOLVED FIXED

[chromium] Move the test implementation of WebKit::WebPlugin to the TestRunner library

Created attachment 178523 [details]
Patch

Darin, could you have a look please?

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Tony Chang]

Comment on attachment 178523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178523&action=review

> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h:49
> +    static WebTestPlugin* Create(WebKit::WebFrame*, const WebKit::WebPluginParams&, WebTestDelegate*);

Create -> create.

Created attachment 178592 [details]
Patch for landing

(In reply to comment #4)
> (From update of attachment 178523 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=178523&action=review
> 
> > Tools/DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h:49
> > +    static WebTestPlugin* Create(WebKit::WebFrame*, const WebKit::WebPluginParams&, WebTestDelegate*);
> 
> Create -> create.

done

Darin, can you cq+ if you're ok with the change?

[WebKit Review Bot]

Comment on attachment 178592 [details]
Patch for landing

Clearing flags on attachment: 178592

Committed r137193: <http://trac.webkit.org/changeset/137193>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.