Bug 104537 - [chromium] Move the test implementation of WebKit::WebPlugin to the TestRunner library
Summary: [chromium] Move the test implementation of WebKit::WebPlugin to the TestRunne...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-10 05:37 PST by jochen
Modified: 2012-12-10 11:53 PST (History)
7 users (show)

See Also:


Attachments
Patch (56.68 KB, patch)
2012-12-10 05:44 PST, jochen
no flags Details | Formatted Diff | Diff
Patch for landing (56.67 KB, patch)
2012-12-10 11:01 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-12-10 05:37:43 PST
[chromium] Move the test implementation of WebKit::WebPlugin to the TestRunner library
Comment 1 jochen 2012-12-10 05:44:35 PST
Created attachment 178523 [details]
Patch
Comment 2 jochen 2012-12-10 05:45:50 PST
Darin, could you have a look please?
Comment 3 WebKit Review Bot 2012-12-10 06:47:32 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Tony Chang 2012-12-10 10:27:50 PST
Comment on attachment 178523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178523&action=review

> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h:49
> +    static WebTestPlugin* Create(WebKit::WebFrame*, const WebKit::WebPluginParams&, WebTestDelegate*);

Create -> create.
Comment 5 jochen 2012-12-10 11:01:17 PST
Created attachment 178592 [details]
Patch for landing
Comment 6 jochen 2012-12-10 11:01:47 PST
(In reply to comment #4)
> (From update of attachment 178523 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=178523&action=review
> 
> > Tools/DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h:49
> > +    static WebTestPlugin* Create(WebKit::WebFrame*, const WebKit::WebPluginParams&, WebTestDelegate*);
> 
> Create -> create.

done
Comment 7 jochen 2012-12-10 11:02:00 PST
Darin, can you cq+ if you're ok with the change?
Comment 8 WebKit Review Bot 2012-12-10 11:53:24 PST
Comment on attachment 178592 [details]
Patch for landing

Clearing flags on attachment: 178592

Committed r137193: <http://trac.webkit.org/changeset/137193>
Comment 9 WebKit Review Bot 2012-12-10 11:53:28 PST
All reviewed patches have been landed.  Closing bug.