[chromium] Move the test implementation of WebKit::WebPlugin to the TestRunner library
Created attachment 178523 [details] Patch
Darin, could you have a look please?
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 178523 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178523&action=review > Tools/DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h:49 > + static WebTestPlugin* Create(WebKit::WebFrame*, const WebKit::WebPluginParams&, WebTestDelegate*); Create -> create.
Created attachment 178592 [details] Patch for landing
(In reply to comment #4) > (From update of attachment 178523 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178523&action=review > > > Tools/DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h:49 > > + static WebTestPlugin* Create(WebKit::WebFrame*, const WebKit::WebPluginParams&, WebTestDelegate*); > > Create -> create. done
Darin, can you cq+ if you're ok with the change?
Comment on attachment 178592 [details] Patch for landing Clearing flags on attachment: 178592 Committed r137193: <http://trac.webkit.org/changeset/137193>
All reviewed patches have been landed. Closing bug.