Bug 104527

Summary: [GTK] Build GObject DOM bindings as a separate library
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia@igalia.com>
Component: WebKit GtkAssignee: Nobody <webkit-unassigned@lists.webkit.org>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth@webkit.org, eric.carlson@apple.com, feature-media-reviews@chromium.org, haraken@chromium.org, japhet@chromium.org, webkit.review.bot@gmail.com, xan.lopez@gmail.com
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch xan.lopez: review+

Description From 2012-12-10 02:20:26 PST
And make independent from webkitgtk lib.
------- Comment #1 From 2012-12-10 02:26:09 PST -------
Created an attachment (id=178496) [details]
Patch
------- Comment #2 From 2012-12-10 02:27:34 PST -------
Attachment 178496 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/bindings/gobject/WebKitDOMBinding.h:29:  Missing spaces around |  [whitespace/operators] [3]
Source/WebCore/bindings/gobject/WebKitDOMBinding.h:30:  Missing spaces around |  [whitespace/operators] [3]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #3 From 2012-12-10 03:38:49 PST -------
(From update of attachment 178496 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=178496&action=review

Let's poke Martin about sharing those bits among the various libraries.

> Source/WebCore/bindings/gobject/WebKitDOMBinding.h:33
>  namespace WebCore {

As we had said I think it could make sense to put this thing somewhere for WebKit1 and WebKit2 to share like we do with other stuff, that way we can avoid duplications.

> Source/WebCore/bindings/scripts/gobject-generate-headers.pl:80
> +

And same with this?
------- Comment #4 From 2012-12-10 03:44:17 PST -------
(From update of attachment 178496 [details])
Looks good to me!
------- Comment #5 From 2012-12-10 04:30:56 PST -------
(From update of attachment 178496 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=178496&action=review

>> Source/WebCore/bindings/gobject/WebKitDOMBinding.h:33
>>  namespace WebCore {
> 
> As we had said I think it could make sense to put this thing somewhere for WebKit1 and WebKit2 to share like we do with other stuff, that way we can avoid duplications.

Yes it can be moved to a common place, but it's just 3 defines, not sure it's worth it.

>> Source/WebCore/bindings/scripts/gobject-generate-headers.pl:80
>> +
> 
> And same with this?

Ditto.
------- Comment #6 From 2012-12-10 09:44:31 PST -------
(From update of attachment 178496 [details])
OK, let's break the build/tests.
------- Comment #7 From 2012-12-10 09:56:13 PST -------
Committed r137173: <http://trac.webkit.org/changeset/137173>