Bug 104516

Summary: [Shadow DOM][Refactoring] HTMLContentElement,HTMLShadowElement::m_registeredWithShadowRoot should be moved to InsertionPoint
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: jberlin, ojan.autocc, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103339    
Attachments:
Description Flags
Patch
none
Patch for landing none

Hajime Morrita
Reported 2012-12-10 00:05:02 PST
There are apparent code duplication. We can pull them up to the super class.
Attachments
Patch (15.81 KB, patch)
2012-12-10 01:39 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.78 KB, patch)
2012-12-10 16:58 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-12-10 01:39:37 PST
Created attachment 178490 [details] Patch
Hajime Morrita
Comment 2 2012-12-10 01:40:36 PST
This is a step forward to hide <content> and <shadow> behind the flag.
WebKit Review Bot
Comment 3 2012-12-10 01:42:39 PST
Attachment 178490 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/html/shadow/ContentDistributor.cpp:115: This { should be at the end of the previous line [whitespace/braces] [4] Source/WebCore/html/shadow/ContentDistributor.cpp:131: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dimitri Glazkov (Google)
Comment 4 2012-12-10 10:25:00 PST
Comment on attachment 178490 [details] Patch Style elf is angry with you.
Hajime Morrita
Comment 5 2012-12-10 16:58:41 PST
Created attachment 178668 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-12-10 17:43:16 PST
Comment on attachment 178668 [details] Patch for landing Clearing flags on attachment: 178668 Committed r137233: <http://trac.webkit.org/changeset/137233>
WebKit Review Bot
Comment 7 2012-12-10 17:43:19 PST
All reviewed patches have been landed. Closing bug.
Jessie Berlin
Comment 8 2012-12-10 19:14:00 PST
Note: build fix is in http://trac.webkit.org/changeset/137240
Note You need to log in before you can comment on or make changes to this bug.