Summary: | [EFL][WK2] Enable TEXT_AUTOSIZING | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jaehun Lim <ljaehun.lim> | ||||||||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED WONTFIX | ||||||||||||||||
Severity: | Normal | CC: | benjamin, cmarcelo, commit-queue, dbates, divakar.a, eflews.bot, gyuyoung.kim, lucas.de.marchi, mcatanzaro, rakuco | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 99074 | ||||||||||||||||
Attachments: |
|
Description
Jaehun Lim
2012-12-09 15:54:59 PST
Created attachment 208239 [details]
Patch
Added patch for enabling TEXT_AUTOSIZING feature on EFL port. (In reply to comment #2) > Added patch for enabling TEXT_AUTOSIZING feature on EFL port. You have to edit Tools/Scripts/webkitperl/FeatureList.pm. Please see http://trac.webkit.org/wiki/AddingFeatures. And you have to resolve the HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP warning issue, too. http://trac.webkit.org/browser/trunk/Source/WebCore/page/Settings.cpp#L131. Created attachment 208320 [details]
Patch
Updated the patch. I did not find any warning related to HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP Comment on attachment 208320 [details] Patch Attachment 208320 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1432111 Comment on attachment 208320 [details] Patch Attachment 208320 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1396120 Created attachment 208333 [details]
Patch
Created attachment 208334 [details]
Patch
Created attachment 208335 [details]
Patch
Corrected error and updated the patch. Comment on attachment 208335 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208335&action=review > Source/WTF/wtf/Platform.h:1061 > +#if PLATFORM(EFL) > +#define HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP 0 > +#endif > + This is not okay. (In reply to comment #12) > (From update of attachment 208335 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208335&action=review > > > Source/WTF/wtf/Platform.h:1061 > > +#if PLATFORM(EFL) > > +#define HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP 0 > > +#endif > > + > > This is not okay. do you want it to be enabled? (In reply to comment #13) > > This is not okay. > do you want it to be enabled? No!!! This should not be in this file. A quick grep shows it is not defined anywhere, you should probably remove HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP from settings. Created attachment 208534 [details]
Patch
Comment on attachment 208534 [details] Patch Attachment 208534 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1441567 Comment on attachment 208534 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208534&action=review > Source/WebCore/page/Settings.cpp:131 > , m_textAutosizingWindowSizeOverride(320, 480) Why are we keeping this line if we are removing HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP? (In reply to comment #17) > (From update of attachment 208534 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208534&action=review > > > Source/WebCore/page/Settings.cpp:131 > > , m_textAutosizingWindowSizeOverride(320, 480) > > Why are we keeping this line if we are removing HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP? "windows size" is used to adjust the font size. If it is not override, "visible contents size" is used instead of it. http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/TextAutosizer.cpp#L116 I think this line is necessary to activate TextAutosizing for the big screen. But I don't like it. Johe Mellor filed the related bug, https://bugs.webkit.org/show_bug.cgi?id=94371 Comment on attachment 208534 [details]
Patch
r- because of failing efl-wk2.
Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. |