Summary: | [CMake] Consolidate list of files to build for WebCore plugin support | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> | ||||||||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, gyuyoung.kim, mxie, paroga, rakuco, rwlbuis, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Laszlo Gombos
2012-12-07 19:54:52 PST
Created attachment 178330 [details]
proposed patch
I only had the opportunity to test it on the EFL port.
Created attachment 178570 [details]
rebase CMakeLists.txt
Created attachment 178579 [details]
right patch this time
Rob, can you help review this patch ? Comment on attachment 178579 [details] right patch this time View in context: https://bugs.webkit.org/attachment.cgi?id=178579&action=review > Source/WebCore/PlatformBlackBerry.cmake:-255 > - plugins/PluginDataNone.cpp Is it correct this one was removed from the list? If it is correct, is it not in use anymore and can we remove the PluginDataNone.cpp? Created attachment 186244 [details]
keep PluginDataNone.cpp for BlackBerry
Thanks Rob for the review. You're right in that PluginDataNone.cpp is still needed for the BlackBerry port.
It seems to me that the file is only used by the BlackBerry port only and can be removed if the BlackBerry port starts to use USE(PLATFORM_STRATEGIES).
Comment on attachment 186244 [details] keep PluginDataNone.cpp for BlackBerry Attachment 186244 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16357200 Comment on attachment 186244 [details] keep PluginDataNone.cpp for BlackBerry Attachment 186244 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16353281 I think this may need another pass, it seems to not pass on win and gtk. (In reply to comment #9) > I think this may need another pass, it seems to not pass on win and gtk. Gtk & Win do not use CMake, so this failures seam unrelated. (In reply to comment #10) > (In reply to comment #9) > > I think this may need another pass, it seems to not pass on win and gtk. > Gtk & Win do not use CMake, so this failures seam unrelated. You are correct. However, efl-wk2 also seems to fail. Laszlo, you want to check and maybe upload a new patch against ToT? Created attachment 201356 [details] rebase on top of r149876 Comment on attachment 201356 [details] rebase on top of r149876 Looks good. Comment on attachment 201356 [details] rebase on top of r149876 Clearing flags on attachment: 201356 Committed r149899: <http://trac.webkit.org/changeset/149899> All reviewed patches have been landed. Closing bug. |