Bug 104429

Summary:

[CMake] Consolidate list of files to build for WebCore plugin support

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gyuyoung.kim, mxie, paroga, rakuco, rwlbuis, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none
rebase CMakeLists.txt	none
right patch this time	none
keep PluginDataNone.cpp for BlackBerry	buildbot: commit-queue-
rebase on top of r149876	none

Laszlo Gombos

Reported 2012-12-07 19:54:52 PST

It seems to me that we can consolidate the list of files to build in the CMake build system and move some some of the files from PlatformXXX.cmake to CMakeLists.txt.

Attachments
proposed patch (4.51 KB, patch) 2012-12-07 19:58 PST, Laszlo Gombos	no flags	Details Formatted Diff Diff
rebase CMakeLists.txt (4.51 KB, patch) 2012-12-10 09:21 PST, Laszlo Gombos	no flags	Details Formatted Diff Diff
right patch this time (4.59 KB, patch) 2012-12-10 10:01 PST, Laszlo Gombos	no flags	Details Formatted Diff Diff
keep PluginDataNone.cpp for BlackBerry (4.44 KB, patch) 2013-02-02 19:11 PST, Laszlo Gombos	buildbot: commit-queue-	Details Formatted Diff Diff
rebase on top of r149876 (4.33 KB, patch) 2013-05-10 09:00 PDT, Laszlo Gombos	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Laszlo Gombos

Comment 1 2012-12-07 19:58:44 PST

Created attachment 178330 [details] proposed patch I only had the opportunity to test it on the EFL port.

Laszlo Gombos

Comment 2 2012-12-10 09:21:09 PST

Created attachment 178570 [details] rebase CMakeLists.txt

Laszlo Gombos

Comment 3 2012-12-10 10:01:30 PST

Created attachment 178579 [details] right patch this time

Laszlo Gombos

Comment 4 2012-12-26 20:14:38 PST

Rob, can you help review this patch ?

Rob Buis

Comment 5 2012-12-28 08:57:21 PST

Comment on attachment 178579 [details] right patch this time View in context: https://bugs.webkit.org/attachment.cgi?id=178579&action=review > Source/WebCore/PlatformBlackBerry.cmake:-255 > - plugins/PluginDataNone.cpp Is it correct this one was removed from the list? If it is correct, is it not in use anymore and can we remove the PluginDataNone.cpp?

Laszlo Gombos

Comment 6 2013-02-02 19:11:26 PST

Created attachment 186244 [details] keep PluginDataNone.cpp for BlackBerry Thanks Rob for the review. You're right in that PluginDataNone.cpp is still needed for the BlackBerry port. It seems to me that the file is only used by the BlackBerry port only and can be removed if the BlackBerry port starts to use USE(PLATFORM_STRATEGIES).

Build Bot

Comment 7 2013-02-02 21:14:31 PST

Comment on attachment 186244 [details] keep PluginDataNone.cpp for BlackBerry Attachment 186244 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16357200

Build Bot

Comment 8 2013-02-02 22:14:40 PST

Comment on attachment 186244 [details] keep PluginDataNone.cpp for BlackBerry Attachment 186244 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16353281

Rob Buis

Comment 9 2013-05-09 12:20:25 PDT

I think this may need another pass, it seems to not pass on win and gtk.

Patrick R. Gansterer

Comment 10 2013-05-09 12:22:31 PDT

(In reply to comment #9) > I think this may need another pass, it seems to not pass on win and gtk. Gtk & Win do not use CMake, so this failures seam unrelated.

Rob Buis

Comment 11 2013-05-09 12:38:36 PDT

(In reply to comment #10) > (In reply to comment #9) > > I think this may need another pass, it seems to not pass on win and gtk. > Gtk & Win do not use CMake, so this failures seam unrelated. You are correct. However, efl-wk2 also seems to fail. Laszlo, you want to check and maybe upload a new patch against ToT?

Laszlo Gombos

Comment 12 2013-05-10 09:00:57 PDT

Created attachment 201356 [details] rebase on top of r149876

Rob Buis

Comment 13 2013-05-10 10:39:28 PDT

Comment on attachment 201356 [details] rebase on top of r149876 Looks good.

WebKit Commit Bot

Comment 14 2013-05-10 12:09:19 PDT

Comment on attachment 201356 [details] rebase on top of r149876 Clearing flags on attachment: 201356 Committed r149899: <http://trac.webkit.org/changeset/149899>

WebKit Commit Bot

Comment 15 2013-05-10 12:09:23 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.