Bug 104401

Summary:

[WK2] Network process should use a correct storage session in private browsing mode

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebKit2

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, jberlin, philn, webkit-ews, xan.lopez

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	webkit-ews: commit-queue-
with a build fix	webkit-ews: commit-queue-
more build fixing	beidson: review+

Alexey Proskuryakov

Reported 2012-12-07 14:20:36 PST

It should! <rdar://problem/12838490>

Attachments
proposed patch (21.79 KB, patch) 2012-12-07 14:31 PST, Alexey Proskuryakov	webkit-ews: commit-queue-	Details Formatted Diff Diff
with a build fix (21.71 KB, patch) 2012-12-07 14:41 PST, Alexey Proskuryakov	webkit-ews: commit-queue-	Details Formatted Diff Diff
more build fixing (21.71 KB, patch) 2012-12-07 14:52 PST, Alexey Proskuryakov	beidson: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2012-12-07 14:31:58 PST

Created attachment 178278 [details] proposed patch

Early Warning System Bot

Comment 2 2012-12-07 14:39:57 PST

Comment on attachment 178278 [details] proposed patch Attachment 178278 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15183560

Alexey Proskuryakov

Comment 3 2012-12-07 14:41:30 PST

Created attachment 178282 [details] with a build fix

Early Warning System Bot

Comment 4 2012-12-07 14:47:20 PST

Comment on attachment 178282 [details] with a build fix Attachment 178282 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15188454

Alexey Proskuryakov

Comment 5 2012-12-07 14:52:52 PST

Created attachment 178285 [details] more build fixing

Brady Eidson

Comment 6 2012-12-07 16:06:04 PST

Comment on attachment 178285 [details] more build fixing View in context: https://bugs.webkit.org/attachment.cgi?id=178285&action=review > Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.h:46 > - RemoteNetworkingContext(bool needsSiteSpecificQuirks, bool localFileContentSniffingEnabled); > + RemoteNetworkingContext(bool needsSiteSpecificQuirks, bool localFileContentSniffingEnabled, bool privateBrowsingEnabled); Could we make this be enums instead of bools?

Alexey Proskuryakov

Comment 7 2012-12-07 16:19:48 PST

Committed <http://trac.webkit.org/changeset/136997>. > Could we make this be enums instead of bools? I'm not sure if we really need to, at least not yet. We primarily use enums for readability, but when we're done hooking up all the arguments, there will be no mysterious false and true literals. Of course, there is the added benefit of type safety, which is worth considering too.

Note You need to log in before you can comment on or make changes to this bug.